Remove zeroLineIndex functionality #6697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
previously approved these changes
Nov 6, 2019
Contributor
benmccann
left a comment
benmccann
left a comment
There was a problem hiding this comment.
lgtm. just one nitpick
kurkle
previously approved these changes
Nov 6, 2019
benmccann
reviewed
Nov 6, 2019
etimberg
force-pushed
the
remove-zero-line-index
branch
from
044decc to
907b081
Compare
benmccann
approved these changes
Nov 6, 2019
kurkle
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
zeroLineIndexfeature. It's not well understood and a pain to use. My plan to replace it was to allow functions to be specified as the options with acontextthat provided the tick value. That would let users control the scale grid lines easily.