Skip to content

Commit 044decc

Browse files
committed
Code review updates
1 parent 3920de4 commit 044decc

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

docs/getting-started/v3-migration.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ Chart.js is no longer providing the `Chart.bundle.js` and `Chart.bundle.min.js`.
2626
### Customizability
2727

2828
* `custom` attribute of elements was removed. Please use scriptable options
29-
* The `zeroLine*` features of axes were removed.
29+
* The `zeroLine*` options of axes were removed.
3030

3131
### Options
3232

src/core/core.scale.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -974,7 +974,7 @@ var Scale = Element.extend({
974974
return alignPixel(chart, pixel, axisWidth);
975975
};
976976
var borderValue, i, tick, lineValue, alignedLineValue;
977-
var tx1, ty1, tx2, ty2, x1, y1, x2, y2, lineWidth, lineColor, borderDash, borderDashOffset;
977+
var tx1, ty1, tx2, ty2, x1, y1, x2, y2;
978978

979979
if (position === 'top') {
980980
borderValue = alignBorderValue(me.bottom);
@@ -1010,10 +1010,10 @@ var Scale = Element.extend({
10101010
continue;
10111011
}
10121012

1013-
lineWidth = valueAtIndexOrDefault(gridLines.lineWidth, i, 1);
1014-
lineColor = valueAtIndexOrDefault(gridLines.color, i, 'rgba(0,0,0,0.1)');
1015-
borderDash = gridLines.borderDash || [];
1016-
borderDashOffset = gridLines.borderDashOffset || 0.0;
1013+
const lineWidth = valueAtIndexOrDefault(gridLines.lineWidth, i, 1);
1014+
const lineColor = valueAtIndexOrDefault(gridLines.color, i, 'rgba(0,0,0,0.1)');
1015+
const borderDash = gridLines.borderDash || [];
1016+
const borderDashOffset = gridLines.borderDashOffset || 0.0;
10171017

10181018
lineValue = getPixelForGridLine(me, tick._index || i, offsetGridLines);
10191019

0 commit comments

Comments
 (0)