fix: renderer race condition #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caarlos0
approved these changes
Jul 27, 2023
3 tasks
aymanbagabas
added a commit
to charmbracelet/soft-serve
that referenced
this pull request
Jul 27, 2023
aymanbagabas
added a commit
to charmbracelet/soft-serve
that referenced
this pull request
Jul 27, 2023
aymanbagabas
added a commit
to charmbracelet/soft-serve
that referenced
this pull request
Jul 28, 2023
aymanbagabas
added a commit
to charmbracelet/soft-serve
that referenced
this pull request
Jul 28, 2023
aymanbagabas
added a commit
to muesli/termenv
that referenced
this pull request
Jul 28, 2023
Make output profile accessible through `ColorProfile`. Use `SetColorProfile` to change the output color profile. Use a mutex to guard output writes. Fixes: charmbracelet/lipgloss#210 Fixes: #145
aymanbagabas
added a commit
to muesli/termenv
that referenced
this pull request
Jul 28, 2023
Make output profile accessible through `ColorProfile`. Use `SetColorProfile` to change the output color profile. Use a mutex to guard output writes. Use pointer receiver Fixes: charmbracelet/lipgloss#210 Fixes: #145
aymanbagabas
added a commit
to muesli/termenv
that referenced
this pull request
Jul 28, 2023
BREAKING! `ColorProfile` reads the terminal environment every time the function is called. This is inefficient. We only need to read the `$TERM` environment variable once when we initialize the output. So we cache the value we read. Rename `ColorProfile` to `termColorProfile` and rely on `EnvColorProfile` to detect the profile. Ideally, we rely on the terminal Terminfo to detect the profile and fallback to the environment. Make output profile accessible through `ColorProfile`. Use `SetColorProfile` to change the output color profile. Use a mutex to guard output writes. Use pointer receiver since we have a lock in the struct Fixes: charmbracelet/lipgloss#210 Fixes: #145
aymanbagabas
added a commit
to muesli/termenv
that referenced
this pull request
Jul 28, 2023
`ColorProfile` reads the terminal environment every time the function is called. This is inefficient. We only need to read the `$TERM` environment variable once when we initialize the output. So instead, we cache the value we read. Rename `ColorProfile` to `termColorProfile` and rely on `EnvColorProfile` to detect the profile. Ideally, we would rely on the terminal Terminfo to detect the profile and fallback to the environment. But that's for another day :) Make output profile accessible through `ColorProfile`. Use `SetColorProfile` to change the output color profile. Use a mutex to guard output writes. Use pointer receiver since we have a lock in the struct Fixes: charmbracelet/lipgloss#210 Fixes: #145
aymanbagabas
added a commit
to muesli/termenv
that referenced
this pull request
Jul 28, 2023
`ColorProfile` reads the terminal environment every time the function is called. This is inefficient. We only need to read the `$TERM` environment variable once when we initialize the output. So instead, we cache the value we read. Rename `ColorProfile` to `termColorProfile` and rely on `EnvColorProfile` to detect the profile. Ideally, we would rely on the terminal Terminfo to detect the profile and fallback to the environment. But that's for another day :) Make output profile accessible through `ColorProfile`. Use `SetColorProfile` to change the output color profile. Use a mutex to guard output writes. Use pointer receiver since we have a lock in the struct Fixes: charmbracelet/lipgloss#210 Fixes: #145
aymanbagabas
force-pushed
the
fix-race
branch
2 times, most recently
from
ae7c722 to
4100381
Compare
Guard accessing the underlying Termenv output behind a mutex. Multiple goroutines can set/get the dark background color causing a race condition. Needs: muesli/termenv#146
aymanbagabas
added a commit
to muesli/termenv
that referenced
this pull request
Jul 28, 2023
Use a mutex to guard setting/getting the color profile and fg/bg colors. Use `SetColorProfile` to change the output color profile. Use pointer receiver since we have a lock in the struct. Fixes: charmbracelet/lipgloss#210 Fixes: #145
aymanbagabas
added a commit
to muesli/termenv
that referenced
this pull request
Jul 28, 2023
Use a mutex to guard setting/getting the color profile and fg/bg colors. Use `SetColorProfile` to change the output color profile. Use pointer receiver since we have a lock in the struct. Fixes: charmbracelet/lipgloss#210 Fixes: #145
caarlos0
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guard accessing the underlying Termenv output behind a mutex. Multiple goroutines can set/get the dark background color causing a race condition.
Needs: muesli/termenv#146