Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more integration tests #352

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Add more integration tests #352

merged 4 commits into from
Dec 11, 2023

Conversation

aymanbagabas
Copy link
Member

@aymanbagabas aymanbagabas commented Jul 26, 2023 •
edited
Loading

  • Main screen SSH UI
  • soft man manual pages
  • Git SSH LFS Transfer

@aymanbagabas aymanbagabas requested a review from caarlos0 July 26, 2023 23:39
caarlos0
caarlos0 approved these changes Jul 27, 2023
View reviewed changes
testscript/testdata/ui-home.txtar Outdated Show resolved Hide resolved
@aymanbagabas aymanbagabas force-pushed the lfs-config branch 4 times, most recently from 3585140 to 06dbd38 Compare July 27, 2023 16:34
@aymanbagabas aymanbagabas force-pushed the lfs-config branch 2 times, most recently from 70b1bd9 to 1451864 Compare July 28, 2023 14:39
Base automatically changed from lfs-config to access-token July 28, 2023 15:30
Base automatically changed from access-token to http-auth July 28, 2023 15:31
Base automatically changed from http-auth to lfs-ssh July 28, 2023 15:32
@aymanbagabas aymanbagabas force-pushed the lfs-ssh branch 7 times, most recently from e861c74 to 36698d2 Compare July 31, 2023 23:18
Base automatically changed from lfs-ssh to main August 4, 2023 14:54
@codecov Codecov
Copy link

codecov bot commented Dec 7, 2023 •
edited
Loading

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (d483565) 47.68% compared to head (df7a932) 56.42%.
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/daemon/daemon.go 42.85% 6 Missing and 2 partials ⚠️
cmd/soft/serve/serve.go 71.42% 3 Missing and 1 partial ⚠️
pkg/web/http.go 60.00% 2 Missing ⚠️
pkg/ssh/cmd/git.go 0.00% 0 Missing and 1 partial ⚠️
pkg/web/git.go 0.00% 0 Missing and 1 partial ⚠️
pkg/webhook/push.go 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
+ Coverage   47.68%   56.42%   +8.73%     
==========================================
  Files         154      157       +3     
  Lines       13092    13454     +362     
==========================================
+ Hits         6243     7591    +1348     
+ Misses       6361     5256    -1105     
- Partials      488      607     +119

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aymanbagabas aymanbagabas force-pushed the ui-test branch 5 times, most recently from efabb0e to fe56722 Compare December 7, 2023 18:49
@aymanbagabas
feat: test ssh ui output
ef251f9 
Still wip

wip

feat(tests): run against ssh ui
@aymanbagabas aymanbagabas changed the title feat: test ui using golden files feat: test ssh ui output Dec 7, 2023
@aymanbagabas aymanbagabas marked this pull request as ready for review December 7, 2023 18:54
@aymanbagabas aymanbagabas requested a review from caarlos0 December 7, 2023 18:54
@aymanbagabas aymanbagabas changed the title feat: test ssh ui output Add more integration tests Dec 7, 2023
@aymanbagabas aymanbagabas merged commit c3915b2 into main Dec 11, 2023
11 checks passed
@aymanbagabas aymanbagabas deleted the ui-test branch December 11, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caarlos0 caarlos0 Awaiting requested review from caarlos0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aymanbagabas @caarlos0