Limit the maximum number of retries for starting opsqueue#31
Limit the maximum number of retries for starting opsqueue#31OpsBotPrime merged 1 commit intomasterfrom
Conversation
We should eventually fail if we can't start the server.
There was a problem hiding this comment.
Pull request overview
This PR modifies the server startup retry behavior to fail after a limited number of attempts rather than retrying indefinitely. This ensures that if the server cannot be started (e.g., due to missing dependencies like rust-src for Rust analyzer), it will eventually fail with a clear error instead of retrying forever.
Key Changes:
- Changed the server startup retry policy from unlimited retries to a maximum of 10 attempts
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@ReinierMaas I'm only back next week so ask Sander or Adrian for a review if you want it before then. |
SanderHageman
changed the title
|
@OpsBotPrime merge |
|
Merge rejected: the base branch of this pull request must be set to master. It is currently set to reinier/log-bound-server-port. |
|
@OpsBotPrime merge |
|
Rebased as ace9951, waiting for CI … |
|
CI job 🟡 started. |
Changes: - Log the locally bound server address on startup, for easier debugging, especially when the port is randomly bound (PR #30 ) - Limit the maximum number of retries when starting Opsqueue and it failing to connect to a port. (PR #31 ) - Ensure `rust-src` is included in the `default.nix` shell, allowing the Rust language server to work without having to pull in the rust stdlib src outside of Nix. (PR #32)
4 participants
We should eventually fail if we can't start the server.