Merged
Conversation
This includes the port that is selected if one tries to bind to port `0`.
There was a problem hiding this comment.
Pull request overview
This PR improves debuggability by logging the actual bound server address instead of the requested address. This is particularly useful when using port 0 (ephemeral port assignment), where the OS assigns an available port at runtime.
Key Changes:
- Moved server address logging from application startup to after TCP listener binding
- Log now displays the actual bound address (e.g., "0.0.0.0:45953") rather than the requested address
- Added error handling for cases where the locally bound address cannot be retrieved
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| opsqueue/src/server.rs | Added logging of actual bound address using listener.local_addr() with error handling; also modified retry policy (unrelated change) |
| opsqueue/app/main.rs | Removed old logging statement that showed requested address instead of actual bound address |
| default.nix | Added "rust-src" extension to Rust toolchain (unrelated change) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ReinierMaas
force-pushed
the
reinier/log-bound-server-port
branch
from
ace9951 to
6eb18fe
Compare
SanderHageman
approved these changes
Dec 24, 2025
Contributor
|
@OpsBotPrime merge |
Contributor
|
Rebased as 6eb18fe, waiting for CI … |
Contributor
|
CI job 🟡 started. |
Qqwy
added a commit
that referenced
this pull request
Dec 30, 2025
Changes: - Log the locally bound server address on startup, for easier debugging, especially when the port is randomly bound (PR #30 ) - Limit the maximum number of retries when starting Opsqueue and it failing to connect to a port. (PR #31 ) - Ensure `rust-src` is included in the `default.nix` shell, allowing the Rust language server to work without having to pull in the rust stdlib src outside of Nix. (PR #32)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logging the actually bound port is good for debug-ability: