Fixes issue with removing objects from scene that don't have materials (...

[saebyn]

...e.g. cameras).

[saebyn]

Not quite, since if object.material is undefined, this will throw an error.
My pull request adds an additional check before dereferencing on
object.material to prevent the TypeError when removing things, like cameras
that don't have materials, from the scene.

On Sun, Sep 8, 2013 at 2:32 PM, Yousef Amar notifications@github.comwrote:

Beat you to it, buddy. :) -> 20fe58420fe584

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/126#issuecomment-24029991
.

[yousefamar]

Yeah, realized a second after posting and it made sense. That's why I deleted my comment. My bad!

[saebyn]

No problem :) I was confused why I didn't see your comment on github, but I
guess that explains it.

On Sun, Sep 8, 2013 at 2:42 PM, Yousef Amar notifications@github.comwrote:

Yeah, realized a second after posting and it made sense. That's why I
deleted my comment. My bad!

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/126#issuecomment-24030184
.

[juanpscotto]

Hi, I have the same error when removing a arrowHelper from the scene: Here is my code:

var arrow = new THREE.ArrowHelper( new THREE.Vector3( 0, -1, 0 ), new THREE.Vector3( 0, 0, 0 ), 5 , 0x0D6759);
arrow .is_arrow = true;
arrow.position.set(0, 0, 0);
scene.add( vectorComponenteVelocidadY );

This is my function to remove all the arrows from the scene;
function removeArrow()
{
var obj, i;
for ( i = scene.children.length - 1; i >= 0 ; i -- ) {
obj = scene.children[ i ];
if ( obj.is_arrow) {
scene.remove(obj);
}
}
}

But it only remove one, and it gives me the following error:
TypeError: object.material is undefined

...material._physijs && this._materials_ref_counts.hasOwnProperty( object.material._p...

What Can I do to delete them all? Thanks.

[chandlerprall]

Try using the most recent versions of physi.js and physijs_worker.js, the error you're seeing should be fixed.

[juanpscotto]

Thank you very much, I just applied the patch you did me lasta time, now I downloaded all the files again and it works perfect!.