Skip to content

Conversation

@yebai
Copy link
Member

@yebai yebai commented May 8, 2025

No description provided.

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
yebai added 4 commits May 9, 2025 11:26
Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
@yebai yebai changed the title Update known_limitations.md unify known limitations into one page May 9, 2025
yebai added 3 commits May 9, 2025 17:50
Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Signed-off-by: Shravan Goswami <123811742+shravanngoswamii@users.noreply.github.com>
@chalk-lab chalk-lab deleted a comment from github-actions bot May 9, 2025
@shravanngoswamii
Copy link
Member

This failed again, I replicated the same workflow in my fork, and it worked fine there, see: shravanngoswamii#1 (comment)

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2025

Mooncake.jl documentation for PR #571 is available at:
https://chalk-lab.github.io/Mooncake.jl/previews/PR571/

@shravanngoswamii
Copy link
Member

If this rerun also fails, then I think we need to add a permission in CI.yml:

permissions:
  contents: write
  pull-requests: write

@shravanngoswamii
Copy link
Member

shravanngoswamii commented May 10, 2025

I am not really getting the reason behind this failure, I tried different cases in my work and all worked fine there, see: shravanngoswamii#6, shravanngoswamii#1, I open PR from branch of base repo, from a fork of fork, from branch of base repo with latest commit from fork, etc...

Let's remove the CI changes from this PR, I will make another PR for fixing it in this repo.
Can you please add me in this repo so I can create a branches?

Signed-off-by: Shravan Goswami <123811742+shravanngoswamii@users.noreply.github.com>
@github-actions
Copy link
Contributor

Performance Ratio:
Ratio of time to compute gradient and time to compute function.
Warning: results are very approximate! See here for more context.

┌────────────────────────────┬──────────┬──────────┬─────────┬─────────────┬─────────┐
│                      Label │   Primal │ Mooncake │  Zygote │ ReverseDiff │  Enzyme │
│                     String │   String │   String │  String │      String │  String │
├────────────────────────────┼──────────┼──────────┼─────────┼─────────────┼─────────┤
│                   sum_1000 │ 100.0 ns │      1.9 │     1.1 │        5.71 │    8.31 │
│                  _sum_1000 │ 941.0 ns │     6.66 │  1410.0 │        32.3 │    1.09 │
│               sum_sin_1000 │  6.57 μs │     2.15 │    1.67 │        10.9 │    2.21 │
│              _sum_sin_1000 │  5.21 μs │     2.62 │   276.0 │        13.3 │     2.5 │
│                   kron_sum │ 292.0 μs │     45.5 │    5.42 │       215.0 │    12.9 │
│              kron_view_sum │ 327.0 μs │     42.6 │    11.1 │       215.0 │    9.63 │
│      naive_map_sin_cos_exp │  2.15 μs │     2.17 │ missing │         7.1 │    2.33 │
│            map_sin_cos_exp │  2.14 μs │     2.37 │    1.57 │        6.04 │    2.89 │
│      broadcast_sin_cos_exp │  2.27 μs │     2.25 │    2.33 │        1.45 │    2.25 │
│                 simple_mlp │ 401.0 μs │     4.58 │    1.61 │        6.75 │    3.28 │
│                     gp_lml │ 243.0 μs │     9.09 │    3.86 │     missing │    7.22 │
│ turing_broadcast_benchmark │  1.98 ms │      3.5 │ missing │        24.0 │ missing │
│         large_single_block │ 390.0 ns │     4.39 │  4350.0 │        30.1 │    2.18 │
└────────────────────────────┴──────────┴──────────┴─────────┴─────────────┴─────────┘

@shravanngoswamii
Copy link
Member

@yebai It's fixed now! It was just a permission issue, I added that in this PR itself!

@yebai yebai merged commit 4fdbf6b into main May 10, 2025
77 checks passed
@yebai yebai deleted the yebai-patch-1 branch May 10, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants