Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect error when calling non-existent symbol property #1501

Closed
wants to merge 1 commit into from
Closed

Fix incorrect error when calling non-existent symbol property #1501

wants to merge 1 commit into from

Commits on Aug 26, 2016

  1. Fix incorrect error when calling non-existent symbol property 

    We threw 'Object does not support ToString' when trying to call a symbol
property on an object when that property didn't exist.  This happened
because we try to do a toString conversion on the index var for the
error message string, but Symbol objects do not support toString via
JavascriptConversion::ToString().

Fix it by special casing symbol properties and directly calling the
static JavascriptSymbol::ToString method to get a useful string.

Fixes chakra-core#1409
    Ian Halliday committed Aug 26, 2016
    Configuration menu
    Copy the full SHA
    2aa29bd View commit details
    Browse the repository at this point in the history