Fix incorrect error when calling non-existent symbol property #1501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We threw 'Object does not support ToString' when trying to call a symbol property on an object when that property didn't exist. This happened because we try to do a toString conversion on the index var for the error message string, but Symbol objects do not support toString via JavascriptConversion::ToString(). Fix it by special casing symbol properties and directly calling the static JavascriptSymbol::ToString method to get a useful string. Fixes chakra-core#1409
Collaborator
Author
|
@tcare @boingoing @Microsoft/chakra-es cc @bterlson |
Contributor
|
Looks good |
Contributor
|
Checked in as 61e4635 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We threw 'Object does not support ToString' when trying to call a symbol
property on an object when that property didn't exist. This happened
because we try to do a toString conversion on the index var for the
error message string, but Symbol objects do not support toString via
JavascriptConversion::ToString().
Fix it by special casing symbol properties and directly calling the
static JavascriptSymbol::ToString method to get a useful string.
Fixes #1409