Port changes from master to fix release/1.3 builds. #1487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the symbol capturing issues This change removes the function wrapper implementation of async functions. Now the async functions will behave similar to generator functions. The actual function body will be in the sciptFunction field. Symbols now need not be forced to slots. asyncspawn opcode and parse node are no more needed.In the backend async functions are also added to the generator JIT flag. await is desugared into yield.
Contributor
Author
|
@dotnet-bot |
Contributor
|
LGTM for my fix |
dilijev
added a commit
that referenced
this pull request
Aug 25, 2016
…ilds. Merge pull request #1487 from dilijev:port-fixes 8290fc6 @Cellule [1.3<master @ 7a7ccac] Resolve missing include for Dev12 build. Fixes #1398 -- 8b988ba @aneeshdk [1.3<master @ a99327b] Updating async function implementation to fix the symbol capturing issues This change removes the function wrapper implementation of async functions. Now the async functions will behave similar to generator functions. The actual function body will be in the sciptFunction field. Symbols now need not be forced to slots. asyncspawn opcode and parse node are no more needed.In the backend async functions are also added to the generator JIT flag. await is desugared into yield.
chakrabot
pushed a commit
that referenced
this pull request
Aug 25, 2016
…elease/1.3 builds. Merge pull request #1487 from dilijev:port-fixes 8290fc6 @Cellule [1.3<master @ 7a7ccac] Resolve missing include for Dev12 build. Fixes #1398 -- 8b988ba @aneeshdk [1.3<master @ a99327b] Updating async function implementation to fix the symbol capturing issues This change removes the function wrapper implementation of async functions. Now the async functions will behave similar to generator functions. The actual function body will be in the sciptFunction field. Symbols now need not be forced to slots. asyncspawn opcode and parse node are no more needed.In the backend async functions are also added to the generator JIT flag. await is desugared into yield.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8290fc6 @Cellule
[1.3<master @ 7a7ccac] Resolve missing include for Dev12 build. Fixes #1398
8b988ba @aneeshdk
[1.3<master @ a99327b] Updating async function implementation to fix the symbol capturing issues
This change removes the function wrapper implementation of async
functions. Now the async functions will behave similar to generator
functions. The actual function body will be in the sciptFunction field.
Symbols now need not be forced to slots. asyncspawn opcode and parse
node are no more needed.In the backend async functions are also
added to the generator JIT flag. await is desugared into yield.