[Legacy] [Linux Branch] {all flavors} Build Error

[dilijev]

https://github.com/Microsoft/ChakraCore/wiki/Build-Status-%28linux%29#legacy-builds

00:15:57 d:\j\workspace\daily_dev12_x---b34c9c6b\lib\common\Codex\Utf8Codex.cpp(486): error C2220: warning treated as error - no 'object' file generated [d:\j\workspace\daily_dev12_x---b34c9c6b\lib\common\Codex\Chakra.Common.Codex.vcxproj]
00:15:57 d:\j\workspace\daily_dev12_x---b34c9c6b\lib\common\Codex\Utf8Codex.cpp(513) : see reference to function template instantiation 'size_t utf8::EncodeIntoImpl<true>(LPUTF8,const char16 *,charcount_t)' being compiled
00:15:57 d:\j\workspace\daily_dev12_x---b34c9c6b\lib\common\Codex\Utf8Codex.cpp(486): warning C4127: conditional expression is constant [d:\j\workspace\daily_dev12_x---b34c9c6b\lib\common\Codex\Chakra.Common.Codex.vcxproj]

Repro locally: https://github.com/Microsoft/ChakraCore/wiki/Jenkins-Repro-Steps#legacy-builds-windows-only

[obastemur]

Some more details on issue;

Helpers.cpp(533): error C2065: 'S_IREAD' : undeclared identifier [d:\j\workspace\daily_dev12_x---c4e76fe7\bin\ch\ch.vcxproj]
02:27:51 Helpers.cpp(533): error C2065: 'S_IWRITE' : undeclared identifier [d:\j\workspace\daily_dev12_x---c4e76fe7\bin\ch\ch.vcxproj]
02:27:51 Helpers.cpp(533): error C2660: '_wchmod' : function does not take 1 arguments [d:\j\workspace\daily_dev12_x---c4e76fe7\bin\ch\ch.vcxproj]

@mrkmarron any idea?

[Cellule]

I didn't realize this issue was for the linux branch at first.
The fix I made was on master.
We should integrate the fix from the master branch to linux.
Do we plan on doing this soon or should I cherry-pick the fix to the linux branch ?

[obastemur]

We do sync master to linux (vice versa) often. So IMHO no need for a separate action.