Skip to content

chore(logs): Deactivate logs retrieval #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

chore(logs): Deactivate logs retrieval #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/chainloop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,10 @@ jobs:
chainloop_attestation_init
echo "CHAINLOOP_ATTESTATION_ID=${CHAINLOOP_ATTESTATION_ID}" >> "$GITHUB_ENV"

- name: logs
run: source <(/usr/local/bin/chainloop_bin/c8l source) && chainloop_collect_logs_for_github_jobs
env:
GH_TOKEN: ${{ github.token }}
# - name: logs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you have a chance to look into the possible root cause?

Do you know if these logs are then chainloop att add'ed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was reading the other day that it could be due to several reasons, including a lack of permissions in the token or the resource not being ready.

The point is that I've ran the same command locally with a failed pipeline and it works.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So token then? I believe we made some changes in the permissions to support slsa, that might be the reason, that we are generating a token that doesn't have enough permissions?

Is that a PAT or an OIDC token?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've compared two Workflow files, one successful and another failing, there are no difference in them:

The one failing is the GitHub token but I don't see any difference in permissions.

# run: source <(/usr/local/bin/chainloop_bin/c8l source) && chainloop_collect_logs_for_github_jobs
# env:
# GH_TOKEN: ${{ github.token }}

# Collect all artifacts, reports, and metadata
# based on the configuration in .chainloop.yml
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/chainloop_push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,10 @@ jobs:
- name: Download all workflow run artifacts
uses: actions/download-artifact@v4

- name: logs
run: source <(/usr/local/bin/chainloop_bin/c8l source) && chainloop_collect_logs_for_github_jobs
env:
GH_TOKEN: ${{ github.token }}
# - name: logs
# run: source <(/usr/local/bin/chainloop_bin/c8l source) && chainloop_collect_logs_for_github_jobs
# env:
# GH_TOKEN: ${{ github.token }}

# Collect all artifacts, reports, and metadata
# based on the configuration in .chainloop.yml
Expand Down