Skip to content

chore(logs): Deactivate logs retrieval #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

Conversation

javirln
Copy link
Member

@javirln javirln commented May 30, 2025

This patch deactivates the logs retrieval from the GitHub workflow until we figure out why it's not working as it used before.

Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
@javirln javirln requested review from migmartri and jiparis May 30, 2025 10:47
@javirln javirln self-assigned this May 30, 2025
run: source <(/usr/local/bin/chainloop_bin/c8l source) && chainloop_collect_logs_for_github_jobs
env:
GH_TOKEN: ${{ github.token }}
# - name: logs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you have a chance to look into the possible root cause?

Do you know if these logs are then chainloop att add'ed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was reading the other day that it could be due to several reasons, including a lack of permissions in the token or the resource not being ready.

The point is that I've ran the same command locally with a failed pipeline and it works.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So token then? I believe we made some changes in the permissions to support slsa, that might be the reason, that we are generating a token that doesn't have enough permissions?

Is that a PAT or an OIDC token?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've compared two Workflow files, one successful and another failing, there are no difference in them:

The one failing is the GitHub token but I don't see any difference in permissions.

@javirln javirln merged commit 1e19b4d into main Jun 5, 2025
3 checks passed
@javirln javirln deleted the deactivate-logs-retrieval branch June 5, 2025 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants