Skip to content

feat: add unique name to cas-backends - #662

Merged
migmartri merged 5 commits into
chainloop-dev:mainfrom
migmartri:cas-backend-name
Apr 11, 2024
Merged

feat: add unique name to cas-backends#662
migmartri merged 5 commits into
chainloop-dev:mainfrom
migmartri:cas-backend-name

Conversation

@migmartri

@migmartri migmartri commented Apr 9, 2024

Copy link
Copy Markdown
Member

Like #523 and #643, this time is turn for the cas-backends.

This feature adds a new name property to our cas-backends entities that needs to be unique and valid in the organization.

This patch also updates existing cas-backends with unique names.

Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri
migmartri marked this pull request as ready for review April 10, 2024 09:58
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri
migmartri requested a review from danlishka April 10, 2024 13:20

@danlishka danlishka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@migmartri
migmartri merged commit a735386 into chainloop-dev:main Apr 11, 2024
@migmartri
migmartri deleted the cas-backend-name branch April 11, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants