Skip to content

feat(controlplane): add unique name to registered integrations - #643

Merged
migmartri merged 2 commits into
chainloop-dev:mainfrom
migmartri:add-name-to-integrations
Apr 1, 2024
Merged

feat(controlplane): add unique name to registered integrations#643
migmartri merged 2 commits into
chainloop-dev:mainfrom
migmartri:add-name-to-integrations

Conversation

@migmartri

@migmartri migmartri commented Apr 1, 2024

Copy link
Copy Markdown
Member

Similarly to other resources (workflows, cas-backends, contracts), now it's turn to registered registrations to have name as unique identifier. The goal of this effort is to enable in the future a declarative configuration approach based on names.

This patch does

  • Adds a new name column along with its database constraint
  • Updates existing data with the kind+id to meet that constraint
  • Registering an integration now requires providing a unique name, this can be done through the CLI.

image

Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri
migmartri requested a review from danlishka April 1, 2024 15:04
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>

@danlishka danlishka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@migmartri
migmartri merged commit b9c81f0 into chainloop-dev:main Apr 1, 2024
@migmartri
migmartri deleted the add-name-to-integrations branch April 1, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants