Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make copy_param support scalar parameters #410

Merged
merged 3 commits into from
Mar 11, 2019
Merged

Make copy_param support scalar parameters #410

merged 3 commits into from
Mar 11, 2019

Conversation

muupan
Copy link
Member

@muupan muupan commented Mar 10, 2019

Current copy_param does not support scalar parameters due to use of [:]. This PR fixes the issue by switching to [...].

toslunar
toslunar reviewed Mar 11, 2019
View reviewed changes
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toslunar
Copy link
Member

I tried to restart the Travis build after #411 is merged, but it was not tested with Python 3.6. Could you merge master?

@muupan
Copy link
Member Author

muupan commented Mar 11, 2019

Now tested with Python 3.6.

@muupan muupan merged commit 3522f58 into chainer:master Mar 11, 2019
@muupan muupan deleted the copy-scalar-param branch March 11, 2019 07:18
@muupan muupan added this to the v0.7 milestone Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toslunar toslunar toslunar left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@muupan @toslunar