Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Python 3.6 in Travis CI #411

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Use Python 3.6 in Travis CI #411

merged 1 commit into from
Mar 11, 2019

Conversation

muupan
Copy link
Member

@muupan muupan commented Mar 10, 2019

This PR fixes the error of from typing import Type in Travis CI caused by tornado==6.0.1 by switching from Python 3.5 to 3.6.

https://travis-ci.org/chainer/chainerrl/jobs/504242079

prabhatnagarajan
prabhatnagarajan approved these changes Mar 10, 2019
View reviewed changes
Copy link
Contributor

@prabhatnagarajan prabhatnagarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;

@toslunar
Copy link
Member

LGTM, too

@toslunar toslunar merged commit c8d5cbb into chainer:master Mar 11, 2019
@toslunar toslunar mentioned this pull request Mar 11, 2019
Merged
@muupan muupan added this to the v0.7 milestone Jun 28, 2019
@muupan muupan added the test label Jun 28, 2019
toslunar added a commit to toslunar/chainerrl that referenced this pull request Jun 28, 2019
@toslunar
Fix Python version for ipynb
6642dd8 
Amend 4902e81 (chainer#411)
@toslunar toslunar mentioned this pull request Jun 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prabhatnagarajan prabhatnagarajan prabhatnagarajan approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@muupan @toslunar @prabhatnagarajan