This repository has been archived by the owner on Jul 2, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 303
Add sequential_feature_extractor #342
Merged
Hakuyume
merged 37 commits into
chainer:master
from
yuyu2172:sequential-feature-extractor
Jul 17, 2017
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
75ad8e7
add sequential_feature_extractor
yuyu2172 817d4e4
improve doc
yuyu2172 4601ed1
fix doc
yuyu2172 3c031d4
fix doc
yuyu2172 b6d618a
fix doc
yuyu2172 d1790a5
remove unnecessary []
yuyu2172 ec70c8f
drop support for list layers
yuyu2172 1cad17b
add to doc
yuyu2172 321ee42
use init_scope
Hakuyume 644ce71
update test
Hakuyume 958913e
update docs
Hakuyume 4af9fc8
remove unused import
Hakuyume d02e8ce
support None
Hakuyume 064c7bc
check if a layer is used in layer_names
Hakuyume 08f1ba7
improve test
Hakuyume 8e80d7b
use tuple
Hakuyume 210f3d2
remove list
Hakuyume 5e31464
add deletion test
Hakuyume a0f4fcf
force tuple
Hakuyume 97778d1
fix test
Hakuyume 6036240
fix docs
Hakuyume 29faace
update docs
Hakuyume 4870aaa
fix docs
Hakuyume 49c490e
Merge pull request #2 from Hakuyume/use-init-scope-in-sequential-feat…
yuyu2172 73e7189
delete imoprt collections
yuyu2172 869dcaf
layer_names --> feature_names
yuyu2172 4168f06
fix doc
yuyu2172 faa7f22
flake8
yuyu2172 4fdc7d6
fix getter
Hakuyume 9a3fdee
add test
Hakuyume aaf403c
add comment
Hakuyume cae3e59
member variable -> attribute
Hakuyume ffd8152
the
Hakuyume e9f5af2
move comment
Hakuyume c57dd3b
Merge pull request #3 from Hakuyume/fix-feature-names-getter-in-seque…
yuyu2172 b2e012d
add a test when there are two same keys in feature_names
yuyu2172 b053036
Merge branch 'sequential-feature-extractor' of https://github.com/yuy…
yuyu2172 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix doc
- Loading branch information
commit b6d618aa2567664e804544a0d6192838486e49a2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,21 +9,21 @@ class SequentialFeatureExtractor(chainer.Chain): | |
|
||
This class is a base class that can be used for an implementation of | ||
a feature extractor model. | ||
The link takes as an argument :obj:`layers` that specifies the computation | ||
The link takes an argument :obj:`layers` that specifies the computation | ||
conducted in :meth:`__call__`. | ||
:obj:`layers` is a list or :obj:`collections.OrderedDict` of | ||
:obj:`layers` is a list or :class:`collections.OrderedDict` of | ||
callable objects called layers, which are going to be called sequentially | ||
starting from the top to the end. | ||
A :obj:`chainer.Link` object in the sequence will be added as | ||
starting from the top to the bottom. | ||
A :class:`chainer.Link` object in the sequence will be added as | ||
a child link of this object. | ||
|
||
:meth:`__call__` returns single or multiple features that are picked up | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, it is OK. |
||
through a stream of computation. | ||
These features can be specified by :obj:`layer_names`, which contains | ||
the names of the layers whose output is collected. | ||
the names of the layers whose outputs are collected. | ||
When :obj:`layer_names` is a string, single value is returned. | ||
When :obj:`layer_names` is an iterable of strings, a tuple of values | ||
will be returned. The order of the values is the same as the order of | ||
is returned. The order of the values is the same as the order of | ||
the strings in :obj:`layer_names`. | ||
|
||
Examples: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
features that are
->feature(s) that is/are
? (I'm not sure)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding a sentence after this one saying
"Note that the number of features can be one."
I think it is better to make all the related nouns plural because there will be too many
X(s)
in this paragraph.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you. I could understand that the number of features can be one. This was only a grammatical question.