Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

Add sequential_feature_extractor #342

Merged
merged 37 commits into from
Jul 17, 2017
Merged

Add sequential_feature_extractor #342

Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
75ad8e7
add sequential_feature_extractor
yuyu2172 Jul 14, 2017
817d4e4
improve doc
yuyu2172 Jul 14, 2017
4601ed1
fix doc
yuyu2172 Jul 14, 2017
3c031d4
fix doc
yuyu2172 Jul 14, 2017
b6d618a
fix doc
yuyu2172 Jul 14, 2017
d1790a5
remove unnecessary []
yuyu2172 Jul 14, 2017
ec70c8f
drop support for list layers
yuyu2172 Jul 14, 2017
1cad17b
add to doc
yuyu2172 Jul 14, 2017
321ee42
use init_scope
Hakuyume Jul 15, 2017
644ce71
update test
Hakuyume Jul 15, 2017
958913e
update docs
Hakuyume Jul 15, 2017
4af9fc8
remove unused import
Hakuyume Jul 15, 2017
d02e8ce
support None
Hakuyume Jul 15, 2017
064c7bc
check if a layer is used in layer_names
Hakuyume Jul 15, 2017
08f1ba7
improve test
Hakuyume Jul 15, 2017
8e80d7b
use tuple
Hakuyume Jul 15, 2017
210f3d2
remove list
Hakuyume Jul 15, 2017
5e31464
add deletion test
Hakuyume Jul 15, 2017
a0f4fcf
force tuple
Hakuyume Jul 15, 2017
97778d1
fix test
Hakuyume Jul 15, 2017
6036240
fix docs
Hakuyume Jul 15, 2017
29faace
update docs
Hakuyume Jul 15, 2017
4870aaa
fix docs
Hakuyume Jul 15, 2017
49c490e
Merge pull request #2 from Hakuyume/use-init-scope-in-sequential-feat…
yuyu2172 Jul 15, 2017
73e7189
delete imoprt collections
yuyu2172 Jul 15, 2017
869dcaf
layer_names --> feature_names
yuyu2172 Jul 15, 2017
4168f06
fix doc
yuyu2172 Jul 16, 2017
faa7f22
flake8
yuyu2172 Jul 16, 2017
4fdc7d6
fix getter
Hakuyume Jul 16, 2017
9a3fdee
add test
Hakuyume Jul 16, 2017
aaf403c
add comment
Hakuyume Jul 16, 2017
cae3e59
member variable -> attribute
Hakuyume Jul 16, 2017
ffd8152
the
Hakuyume Jul 16, 2017
e9f5af2
move comment
Hakuyume Jul 16, 2017
c57dd3b
Merge pull request #3 from Hakuyume/fix-feature-names-getter-in-seque…
yuyu2172 Jul 16, 2017
b2e012d
add a test when there are two same keys in feature_names
yuyu2172 Jul 17, 2017
b053036
Merge branch 'sequential-feature-extractor' of https://github.com/yuy…
yuyu2172 Jul 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix docs
  • Loading branch information
@Hakuyume
Hakuyume committed Jul 15, 2017
commit 6036240d5cfaad381040bcbc74599e98b8b331a5
10 changes: 5 additions & 5 deletions chainercv/links/model/sequential_feature_extractor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@ class SequentialFeatureExtractor(chainer.Chain):

This class is a base class that can be used for an implementation of
a feature extractor model.
Callabel objects, such as :class:`chainer.Link` and
:class:`chainer.Function`, can be registered to this link with
Callable objects, such as :class:`chainer.Link` and
:class:`chainer.Function`, can be registered to this chain with
:meth:`init_scope`.
This link keeps the order of registerations and conducts the computation
in the same order when :meth:`__call__` is called.
This link keeps the order of registerations and :meth:__call__
executes callables in the order in which they are registered to.
A :class:`chainer.Link` object in the sequence will be added as
a child link of this object.
a child link of this link.

:meth:`__call__` returns single or multiple features that are picked up
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

features that are -> feature(s) that is/are ? (I'm not sure)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding a sentence after this one saying

"Note that the number of features can be one."

I think it is better to make all the related nouns plural because there will be too many X(s) in this paragraph.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you. I could understand that the number of features can be one. This was only a grammatical question.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that -> those

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is OK.
It works like which.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it is OK.

through a stream of computation.
Expand Down