Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removes ?? for node compat #1574

Merged
merged 1 commit into from
Jan 12, 2024
Merged

fix: removes ?? for node compat #1574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: removes ?? for node compat 
We shipped syntax which is beyond our `engine` constraint. `??` is
available in node 14 but 4.x is node 4 and above, while 5.x is node 12
and above.

This just dumbs it back down to `||` for now at least.

Fixes #1573
  • Loading branch information
@43081j
43081j committed Jan 10, 2024
commit ad33e8f0ba725965730e912572e77bb2014c5a2b
2 changes: 1 addition & 1 deletion lib/chai/assertion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ module.exports = function (_chai, util) {
flag(this, 'lockSsfi', lockSsfi);
flag(this, 'object', obj);
flag(this, 'message', msg);
flag(this, 'eql', config.deepEqual ?? util.eql);
flag(this, 'eql', config.deepEqual || util.eql);

return util.proxify(this);
}
Expand Down