fix: removes ?? for node compat
#1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shipped syntax which is beyond our `engine` constraint. `??` is available in node 14 but 4.x is node 4 and above, while 5.x is node 12 and above. This just dumbs it back down to `||` for now at least. Fixes chaijs#1573
keithamus
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
I think to keep them in sync, for now, making 2 PRs will suffice. We'll figure out a better way of dealing with this overtime, perhaps.
Perhaps one way of dealing with this is to make the changes in main, then when we release a 5.x.x version, we should go back and backport those changes to 4.x.x.
|
Hi, by when can we expect these changes to be merged and the issue to be resolved ? |
mattgodbolt
referenced
this pull request
in compiler-explorer/compiler-explorer
Jan 15, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [chai](http://chaijs.com) ([source](https://togithub.com/chaijs/chai)) | [`^4.3.10` -> `^4.4.1`](https://renovatebot.com/diffs/npm/chai/4.4.0/4.4.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>chaijs/chai (chai)</summary> ### [`v4.4.1`](https://togithub.com/chaijs/chai/releases/tag/v4.4.1) [Compare Source](https://togithub.com/chaijs/chai/compare/v4.4.0...v4.4.1) #### What's Changed - fix: removes `??` for node compat by [@​43081j](https://togithub.com/43081j) in [https://github.com/chaijs/chai/pull/1574](https://togithub.com/chaijs/chai/pull/1574) **Full Changelog**: chaijs/chai@v4.4.0...v4.4.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 8pm on monday" in timezone America/Chicago, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/compiler-explorer/compiler-explorer). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 task
This was referenced May 21, 2024
This was referenced May 24, 2024
Open
Open
Open
This was referenced May 24, 2024
This was referenced Sep 21, 2024
Open
This was referenced Sep 22, 2024
This was referenced Sep 23, 2024
Open
This was referenced Sep 24, 2024
This was referenced Nov 1, 2024
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shipped syntax which is beyond our
engineconstraint.??is available in node 14 but 4.x is node 4 and above, while 5.x is node 12 and above.This just dumbs it back down to
||for now at least.Fixes #1573
@koddsson @keithamus can we just catch 5.x up from 4.x when this lands? how do we deal with keeping them in sync, as 5 needs this too