Shade dagger dep, to avoid leaking into a kapt dagger compilation. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgruber
force-pushed
the
dagger_jarjar
branch
2 times, most recently
from
e5857f7
to
7913363
Compare
…shade dagger, avoiding leakage of the bytecode from the builder into compilation jobs peformed by the builder. Fixes bazelbuild#192
|
Ugh. checks are messed up. I'm going to close this and re-issue, since it's now building properly on buildkite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update maven dependencies, and invoke jarjar on the kotlinbuilder to shade dagger, avoiding leakage of the bytecode from the builder into compilation jobs peformed by the builder.
Fixes bazelbuild#192