-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KotlinBuilder leaks dagger dependency into compilation. #192
Comments
Gonna suggest probably shading, as it's the simplest option, architecturally. Just changes the packaging step. |
cgruber
added a commit
to cgruber/rules_kotlin
that referenced
this issue
Jun 12, 2019
…shade dagger, avoiding leakage of the bytecode from the builder into compilation jobs peformed by the builder. Fixes bazelbuild#192
cgruber
added a commit
to cgruber/rules_kotlin
that referenced
this issue
Jun 12, 2019
…shade dagger, avoiding leakage of the bytecode from the builder into compilation jobs peformed by the builder. Fixes bazelbuild#192
cgruber
added a commit
to cgruber/rules_kotlin
that referenced
this issue
Jun 12, 2019
…shade dagger, avoiding leakage of the bytecode from the builder into compilation jobs peformed by the builder. Fixes bazelbuild#192
cgruber
added a commit
to cgruber/rules_kotlin
that referenced
this issue
Jun 12, 2019
…shade dagger, avoiding leakage of the bytecode from the builder into compilation jobs peformed by the builder. Fixes bazelbuild#192
This fix is released in https://github.com/cgruber/rules_kotlin/releases/tag/legacy-modded-0_26_1-01 |
jongerrish
added a commit
to jongerrish/rules_kotlin
that referenced
this issue
Apr 16, 2020
…shade dagger, avoiding leakage of the bytecode from the builder into compilation jobs peformed by the builder. Fixes bazelbuild#192
richmowd411
added a commit
to richmowd411/Rules-Kotlin
that referenced
this issue
Apr 12, 2022
…shade dagger, avoiding leakage of the bytecode from the builder into compilation jobs peformed by the builder. Fixes bazelbuild/rules_kotlin#192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using Dagger >2.21 which introduces a new inner class Component.Factory, compilations that involve dagger processing end up having an older version of Dagger (2.16), which is API incompatible (Component in both versions have different metadata about inner classes). This results in compile-time crashes during annotation processing.
This likely means that however kapt is being invoked, the builder itself is in the classpath, probably because the builder is invoking kapt in its process.
The correct action would be to isolate classloaders.
Possible backups would include:
The text was updated successfully, but these errors were encountered: