feat: support namespaceSelector matchExpressions #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cert-manager-prow
bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
size/L
erikgb
force-pushed
the
namespace-match-expressions
branch
2 times, most recently
from
abc3db3
to
d5ffbc7
Compare
erikgb
changed the title
cert-manager-prow
bot
removed
the
do-not-merge/work-in-progress
erikgb
force-pushed
the
namespace-match-expressions
branch
2 times, most recently
from
fccfd46
to
cde993f
Compare
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
erikgb
force-pushed
the
namespace-match-expressions
branch
from
cde993f
to
9dffd35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And use upstream code to validate label selectors. I am in doubt if additional tests are required. Somehow it feels wrong to test upstream features here. They are certainly tested upstream. WDYT?
Close #302