Add matchExpressions to Bundle's spec.target.namespaceSelector

[sathieu]

Currently, bundle has:

spec:
  target:
    namespaceSelector:
      matchLabels:
        linkerd.io/inject: "enabled"

We need support for:

spec:
  target:
    namespaceSelector:
      matchExpressions:
      - key: kubitus-project.gitlab.io/inject-ca-bundle
        operator: NotIn
        values:
        - 'false'

Ref: https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#resources-that-support-set-based-requirements

[erikgb]

I think this was discussed in #258 - as this new feature supports all types of selectors. It would make sense to add this IMO, and I also think it could be added non-breaking. PRs welcome! 😸

[sathieu]

@ocampeau Could you please take a look at this feature request 🙏?

[ocampeau]

I think it could be a nice addition yes. This can definitely be done in a non-breaking fashion. The Kubernetes libraries already provides the types for that.

[erikgb]

/help

[cert-manager-prow]

@erikgb:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jsalatiel]

Any updates on this ?