This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-tabs] Deselection of Tab Issue #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
Replace comparing logic with itemkey.
Ignore if it is a negative left position value
Why it was changed:
This issues are reported when the screen is at 400%.
-- Alignment of menu items is not correct when the more button dropdown is opened.
Menu popup is not completely visible, as the half of the menu overlay is getting clipped off from the viewport.
-- De-selection of Tab.
Tab gets deselected on pressing space. And if user tries to navigate with TAB/SHIFT+TAB key then the focus doesn't go to the "More" dropdown.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10370
Thank you for contributing to Terra.
@cerner/terra