[terra-tabs] Deselection of Tab Issue (#2144)

cerner · Apr 25, 2024 · 74e9022 · 74e9022
1 parent 2493c09
commit 74e9022
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/terra-tabs/CHANGELOG.md b/packages/terra-tabs/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+* Fixed
+  * Fixes for deselection of tab within more button.
+  * More button dropdown left position reset to zero when negative.
+
 ## 7.28.0 - (April 23, 2024)
 
 * Changed

diff --git a/packages/terra-tabs/src/common-tabs/_Tabs.jsx b/packages/terra-tabs/src/common-tabs/_Tabs.jsx
@@ -414,7 +414,7 @@ class Tabs extends React.Component {
       offset = parentOffset + leftEdge + widthDelta;
     }
 
-    this.dropdownRef.current.style.left = `${offset}px`;
+    this.dropdownRef.current.style.left = (offset > 0) ? `${offset}px` : '0px';
     // Dropdown menu gets truncated when the left edge is less than or equal to zero. setting min-width will help to fix this issue.
     if (!leftEdge) {
       this.dropdownRef.current.style.minWidth = `${moreRect.width}px`;
@@ -439,7 +439,7 @@ class Tabs extends React.Component {
       if (this.isOpen) {
         const updatedTabData = this.state.visibleTabData.map((tab) => ({
           ...tab,
-          isSelected: tab.id === itemKey,
+          isSelected: tab.itemKey === itemKey,
         }));
         this.setState({ visibleTabData: updatedTabData }, () => {
           onSelect(itemKey, metaData);