rbd: fix mapOptions passing with rbd-nbd mounter #2636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This got removed unintentionally with ceph#2628 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
mergify
bot
added
component/rbd
|
All the tests are hitting a different common issue: https://jenkins-ceph-csi.apps.ocp.ci.centos.org/job/mini-e2e-helm_k8s-1.20/3078/display/redirect https://jenkins-ceph-csi.apps.ocp.ci.centos.org/job/mini-e2e_k8s-1.20/3096/display/redirect nodeplugin logs: Which is different from what we have seen before! |
|
@ceph/ceph-csi-contributors I have reordered the e2e tests in a way that krbd encryption tests runs first, just to prove that the bug is not nbd specific. See latest CI results. I guess we introduced yet another regression in encryption. Anyone know about it? |
but why the E2E is failing only for nbd? can we open a PR to disable nbd and test encryption with krbd to verify the regression? |
@Madhu-1 sorry, I didn't get you. |
|
@ceph/ceph-csi-contributors I don't know why but the mount type is empty instead of Have we seen this before? Or has anyone made changes recently in this code path? |
Madhu-1
reviewed
Nov 15, 2021
Yes, certainly! |
|
Before removing commit 3, which is for reordering tests such a way that the https://jenkins-ceph-csi.apps.ocp.ci.centos.org/job/mini-e2e-helm_k8s-1.20/3079/display/redirect |
|
/retest ci/centos/mini-e2e/k8s-1.22 |
This test should run on the nodeplugin, not inside the application pod... The application may not see, or have sufficient permissions for detecting the block-device type (encrypted or not). |
@nixpanic |
|
/retest ci/centos/mini-e2e-helm/k8s-1.20 |
nixpanic
reviewed
Nov 15, 2021
Rakshith-R
requested changes
Nov 15, 2021
pkalever
force-pushed
the
fix-2610
branch
2 times, most recently
from
425d1ea to
089d34b
Compare
mergify
bot
dismissed stale reviews from Rakshith-R and Madhu-1
Pull request has been modified.
Madhu-1
approved these changes
Nov 16, 2021
|
/retest ci/centos/k8s-e2e-external-storage/1.22 |
Rakshith-R
approved these changes
Nov 16, 2021
nixpanic
approved these changes
Nov 16, 2021
pkalever
pushed a commit
to pkalever/ceph-csi
that referenced
this pull request
Nov 16, 2021
Uses the below schema to supply mounter specific map/unmapOptions to the nodeplugin based on the discussion we all had at ceph#2636 This should specifically be really helpful with the `tryOthermonters` set to true, i.e with fallback mechanism settings turned ON. mapOption: "kbrd:v1,v2,v3;nbd:v1,v2,v3" - By omitting `krbd:` or `nbd:`, the option(s) apply to rbdDefaultMounter which is krbd. - A user can _override_ the options for a mounter by specifying `krbd:` or `nbd:`. mapOption: "v1,v2,v3;nbd:v1,v2,v3" is effectively the same as the 1st example. - Sections are split by `;`. - If users want to specify common options for both `krbd` and `nbd`, they should mention them twice. Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
pkalever
pushed a commit
to pkalever/ceph-csi
that referenced
this pull request
Nov 16, 2021
Uses the below schema to supply mounter specific map/unmapOptions to the nodeplugin based on the discussion we all had at ceph#2636 This should specifically be really helpful with the `tryOthermonters` set to true, i.e with fallback mechanism settings turned ON. mapOption: "kbrd:v1,v2,v3;nbd:v1,v2,v3" - By omitting `krbd:` or `nbd:`, the option(s) apply to rbdDefaultMounter which is krbd. - A user can _override_ the options for a mounter by specifying `krbd:` or `nbd:`. mapOption: "v1,v2,v3;nbd:v1,v2,v3" is effectively the same as the 1st example. - Sections are split by `;`. - If users want to specify common options for both `krbd` and `nbd`, they should mention them twice. Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
pkalever
pushed a commit
to pkalever/ceph-csi
that referenced
this pull request
Nov 16, 2021
Uses the below schema to supply mounter specific map/unmapOptions to the nodeplugin based on the discussion we all had at ceph#2636 This should specifically be really helpful with the `tryOthermonters` set to true, i.e with fallback mechanism settings turned ON. mapOption: "kbrd:v1,v2,v3;nbd:v1,v2,v3" - By omitting `krbd:` or `nbd:`, the option(s) apply to rbdDefaultMounter which is krbd. - A user can _override_ the options for a mounter by specifying `krbd:` or `nbd:`. mapOption: "v1,v2,v3;nbd:v1,v2,v3" is effectively the same as the 1st example. - Sections are split by `;`. - If users want to specify common options for both `krbd` and `nbd`, they should mention them twice. Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
pkalever
pushed a commit
to pkalever/ceph-csi
that referenced
this pull request
Nov 16, 2021
Uses the below schema to supply mounter specific map/unmapOptions to the nodeplugin based on the discussion we all had at ceph#2636 This should specifically be really helpful with the `tryOthermonters` set to true, i.e with fallback mechanism settings turned ON. mapOption: "kbrd:v1,v2,v3;nbd:v1,v2,v3" - By omitting `krbd:` or `nbd:`, the option(s) apply to rbdDefaultMounter which is krbd. - A user can _override_ the options for a mounter by specifying `krbd:` or `nbd:`. mapOption: "v1,v2,v3;nbd:v1,v2,v3" is effectively the same as the 1st example. - Sections are split by `;`. - If users want to specify common options for both `krbd` and `nbd`, they should mention them twice. Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
pkalever
pushed a commit
to pkalever/ceph-csi
that referenced
this pull request
Nov 16, 2021
Uses the below schema to supply mounter specific map/unmapOptions to the nodeplugin based on the discussion we all had at ceph#2636 This should specifically be really helpful with the `tryOthermonters` set to true, i.e with fallback mechanism settings turned ON. mapOption: "kbrd:v1,v2,v3;nbd:v1,v2,v3" - By omitting `krbd:` or `nbd:`, the option(s) apply to rbdDefaultMounter which is krbd. - A user can _override_ the options for a mounter by specifying `krbd:` or `nbd:`. mapOption: "v1,v2,v3;nbd:v1,v2,v3" is effectively the same as the 1st example. - Sections are split by `;`. - If users want to specify common options for both `krbd` and `nbd`, they should mention them twice. Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
pkalever
pushed a commit
to pkalever/ceph-csi
that referenced
this pull request
Nov 17, 2021
Uses the below schema to supply mounter specific map/unmapOptions to the nodeplugin based on the discussion we all had at ceph#2636 This should specifically be really helpful with the `tryOthermonters` set to true, i.e with fallback mechanism settings turned ON. mapOption: "kbrd:v1,v2,v3;nbd:v1,v2,v3" - By omitting `krbd:` or `nbd:`, the option(s) apply to rbdDefaultMounter which is krbd. - A user can _override_ the options for a mounter by specifying `krbd:` or `nbd:`. mapOption: "v1,v2,v3;nbd:v1,v2,v3" is effectively the same as the 1st example. - Sections are split by `;`. - If users want to specify common options for both `krbd` and `nbd`, they should mention them twice. Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
pkalever
pushed a commit
to pkalever/ceph-csi
that referenced
this pull request
Nov 17, 2021
Uses the below schema to supply mounter specific map/unmapOptions to the nodeplugin based on the discussion we all had at ceph#2636 This should specifically be really helpful with the `tryOthermonters` set to true, i.e with fallback mechanism settings turned ON. mapOption: "kbrd:v1,v2,v3;nbd:v1,v2,v3" - By omitting `krbd:` or `nbd:`, the option(s) apply to rbdDefaultMounter which is krbd. - A user can _override_ the options for a mounter by specifying `krbd:` or `nbd:`. mapOption: "v1,v2,v3;nbd:v1,v2,v3" is effectively the same as the 1st example. - Sections are split by `;`. - If users want to specify common options for both `krbd` and `nbd`, they should mention them twice. Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
pkalever
pushed a commit
to pkalever/ceph-csi
that referenced
this pull request
Nov 18, 2021
Uses the below schema to supply mounter specific map/unmapOptions to the nodeplugin based on the discussion we all had at ceph#2636 This should specifically be really helpful with the `tryOthermonters` set to true, i.e with fallback mechanism settings turned ON. mapOption: "kbrd:v1,v2,v3;nbd:v1,v2,v3" - By omitting `krbd:` or `nbd:`, the option(s) apply to rbdDefaultMounter which is krbd. - A user can _override_ the options for a mounter by specifying `krbd:` or `nbd:`. mapOption: "v1,v2,v3;nbd:v1,v2,v3" is effectively the same as the 1st example. - Sections are split by `;`. - If users want to specify common options for both `krbd` and `nbd`, they should mention them twice. Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
pkalever
pushed a commit
to pkalever/ceph-csi
that referenced
this pull request
Nov 18, 2021
Uses the below schema to supply mounter specific map/unmapOptions to the nodeplugin based on the discussion we all had at ceph#2636 This should specifically be really helpful with the `tryOthermonters` set to true, i.e with fallback mechanism settings turned ON. mapOption: "kbrd:v1,v2,v3;nbd:v1,v2,v3" - By omitting `krbd:` or `nbd:`, the option(s) apply to rbdDefaultMounter which is krbd. - A user can _override_ the options for a mounter by specifying `krbd:` or `nbd:`. mapOption: "v1,v2,v3;nbd:v1,v2,v3" is effectively the same as the 1st example. - Sections are split by `;`. - If users want to specify common options for both `krbd` and `nbd`, they should mention them twice. Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
pkalever
pushed a commit
to pkalever/ceph-csi
that referenced
this pull request
Nov 18, 2021
Uses the below schema to supply mounter specific map/unmapOptions to the nodeplugin based on the discussion we all had at ceph#2636 This should specifically be really helpful with the `tryOthermonters` set to true, i.e with fallback mechanism settings turned ON. mapOption: "kbrd:v1,v2,v3;nbd:v1,v2,v3" - By omitting `krbd:` or `nbd:`, the option(s) apply to rbdDefaultMounter which is krbd. - A user can _override_ the options for a mounter by specifying `krbd:` or `nbd:`. mapOption: "v1,v2,v3;nbd:v1,v2,v3" is effectively the same as the 1st example. - Sections are split by `;`. - If users want to specify common options for both `krbd` and `nbd`, they should mention them twice. Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
pkalever
pushed a commit
to pkalever/ceph-csi
that referenced
this pull request
Nov 18, 2021
Uses the below schema to supply mounter specific map/unmapOptions to the nodeplugin based on the discussion we all had at ceph#2636 This should specifically be really helpful with the `tryOthermonters` set to true, i.e with fallback mechanism settings turned ON. mapOption: "kbrd:v1,v2,v3;nbd:v1,v2,v3" - By omitting `krbd:` or `nbd:`, the option(s) apply to rbdDefaultMounter which is krbd. - A user can _override_ the options for a mounter by specifying `krbd:` or `nbd:`. mapOption: "v1,v2,v3;nbd:v1,v2,v3" is effectively the same as the 1st example. - Sections are split by `;`. - If users want to specify common options for both `krbd` and `nbd`, they should mention them twice. Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
pkalever
pushed a commit
to pkalever/ceph-csi
that referenced
this pull request
Nov 18, 2021
Uses the below schema to supply mounter specific map/unmapOptions to the nodeplugin based on the discussion we all had at ceph#2636 This should specifically be really helpful with the `tryOthermonters` set to true, i.e with fallback mechanism settings turned ON. mapOption: "kbrd:v1,v2,v3;nbd:v1,v2,v3" - By omitting `krbd:` or `nbd:`, the option(s) apply to rbdDefaultMounter which is krbd. - A user can _override_ the options for a mounter by specifying `krbd:` or `nbd:`. mapOption: "v1,v2,v3;nbd:v1,v2,v3" is effectively the same as the 1st example. - Sections are split by `;`. - If users want to specify common options for both `krbd` and `nbd`, they should mention them twice. Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
pkalever
pushed a commit
to pkalever/ceph-csi
that referenced
this pull request
Nov 18, 2021
Uses the below schema to supply mounter specific map/unmapOptions to the nodeplugin based on the discussion we all had at ceph#2636 This should specifically be really helpful with the `tryOthermonters` set to true, i.e with fallback mechanism settings turned ON. mapOption: "kbrd:v1,v2,v3;nbd:v1,v2,v3" - By omitting `krbd:` or `nbd:`, the option(s) apply to rbdDefaultMounter which is krbd. - A user can _override_ the options for a mounter by specifying `krbd:` or `nbd:`. mapOption: "v1,v2,v3;nbd:v1,v2,v3" is effectively the same as the 1st example. - Sections are split by `;`. - If users want to specify common options for both `krbd` and `nbd`, they should mention them twice. Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
pkalever
pushed a commit
to pkalever/ceph-csi
that referenced
this pull request
Nov 22, 2021
Uses the below schema to supply mounter specific map/unmapOptions to the nodeplugin based on the discussion we all had at ceph#2636 This should specifically be really helpful with the `tryOthermonters` set to true, i.e with fallback mechanism settings turned ON. mapOption: "kbrd:v1,v2,v3;nbd:v1,v2,v3" - By omitting `krbd:` or `nbd:`, the option(s) apply to rbdDefaultMounter which is krbd. - A user can _override_ the options for a mounter by specifying `krbd:` or `nbd:`. mapOption: "v1,v2,v3;nbd:v1,v2,v3" is effectively the same as the 1st example. - Sections are split by `;`. - If users want to specify common options for both `krbd` and `nbd`, they should mention them twice. Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
pkalever
pushed a commit
to pkalever/ceph-csi
that referenced
this pull request
Nov 23, 2021
Uses the below schema to supply mounter specific map/unmapOptions to the nodeplugin based on the discussion we all had at ceph#2636 This should specifically be really helpful with the `tryOthermonters` set to true, i.e with fallback mechanism settings turned ON. mapOption: "kbrd:v1,v2,v3;nbd:v1,v2,v3" - By omitting `krbd:` or `nbd:`, the option(s) apply to rbdDefaultMounter which is krbd. - A user can _override_ the options for a mounter by specifying `krbd:` or `nbd:`. mapOption: "v1,v2,v3;nbd:v1,v2,v3" is effectively the same as the 1st example. - Sections are split by `;`. - If users want to specify common options for both `krbd` and `nbd`, they should mention them twice. Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
mergify bot
pushed a commit
that referenced
this pull request
Nov 23, 2021
Uses the below schema to supply mounter specific map/unmapOptions to the nodeplugin based on the discussion we all had at #2636 This should specifically be really helpful with the `tryOthermonters` set to true, i.e with fallback mechanism settings turned ON. mapOption: "kbrd:v1,v2,v3;nbd:v1,v2,v3" - By omitting `krbd:` or `nbd:`, the option(s) apply to rbdDefaultMounter which is krbd. - A user can _override_ the options for a mounter by specifying `krbd:` or `nbd:`. mapOption: "v1,v2,v3;nbd:v1,v2,v3" is effectively the same as the 1st example. - Sections are split by `;`. - If users want to specify common options for both `krbd` and `nbd`, they should mention them twice. Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
rbd: fix mapOptions passing with rbd-nbd mounter
This was a regression introduced by:
rbd: detect krbd features in runtime and fallback to nbd #2556
e2e: adding io-timeout for lower kernel versions
This got removed unintentionally with
e2e: restrict IO with lower version kernel at rbd-nbd tests #2628
e2e: validate encrypted image mount inside the nodeplugin
currently, the mount type validation of the encrypted volume is done in the application, we should rather validate this inside the nodeplugin pod.
Signed-off-by: Prasanna Kumar Kalever prasanna.kalever@redhat.com
Fixes: #2610.
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any testprogress or results