-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: restrict IO with lower version kernel at rbd-nbd tests #2628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ceph/contributors there are two ways to address #2204:
|
pkalever
force-pushed
the
fix-rbd-nbd-IOE
branch
from
November 9, 2021 12:12
cb196eb
to
8acc2c1
Compare
pkalever
changed the title
e2e: restrict IO for lower version kernel at rbd-nbd tests
e2e: restrict IO with lower version kernel at rbd-nbd tests
Nov 9, 2021
nixpanic
reviewed
Nov 9, 2021
pkalever
force-pushed
the
fix-rbd-nbd-IOE
branch
from
November 9, 2021 13:11
8acc2c1
to
7374078
Compare
nixpanic
approved these changes
Nov 9, 2021
/retest ci/centos/mini-e2e/k8s-1.20 |
Rakshith-R
approved these changes
Nov 10, 2021
pkalever
force-pushed
the
fix-rbd-nbd-IOE
branch
from
November 10, 2021 05:09
7374078
to
1d755e9
Compare
/retest ci/centos/mini-e2e-helm/k8s-1.20 |
Failed with #2610 |
@Mergifyio rebase |
Currently, at "perform IO on rbd-nbd volume after nodeplugin restart" test we are performing write on the rbd-nbd based mount after nodeplugin restart. But due to a bug in NBD driver the writes are failing, please note NBD zero cmd timeout handling is fixed with kernel >= 5.4 and hence we should defend on writes based on kernel version to avoid unnecessary CI failures. For more information see ceph#2204 (comment) updates: ceph#2204 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
✅ Branch has been successfully rebased |
pkalever
force-pushed
the
fix-rbd-nbd-IOE
branch
from
November 10, 2021 11:15
1d755e9
to
861c890
Compare
pkalever
pushed a commit
to pkalever/ceph-csi
that referenced
this pull request
Nov 12, 2021
This got removed unintentionally with ceph#2628 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
pkalever
pushed a commit
to pkalever/ceph-csi
that referenced
this pull request
Nov 14, 2021
This got removed unintentionally with ceph#2628 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
mergify bot
pushed a commit
that referenced
this pull request
Nov 16, 2021
This got removed unintentionally with #2628 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
Currently, at "perform IO on rbd-nbd volume after nodeplugin restart"
test we are performing write on the rbd-nbd based mount after nodeplugin
restart. But due to a bug in NBD driver the writes are failing, please
note NBD zero cmd timeout handling is fixed with kernel >= 5.4 and hence
we should defend on writes based on kernel version to avoid unnecessary
CI failures.
For more information see
#2204 (comment)
updates: #2204
Signed-off-by: Prasanna Kumar Kalever prasanna.kalever@redhat.com
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>
: retest the<job-name>
after unrelatedfailure (please report the failure too!)
/retest all
: run this in case the CentOS CI failed to start/report any testprogress or results