Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: restrict IO with lower version kernel at rbd-nbd tests #2628

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

pkalever
Copy link

@pkalever pkalever commented Nov 9, 2021

Describe what this PR does

Currently, at "perform IO on rbd-nbd volume after nodeplugin restart"
test we are performing write on the rbd-nbd based mount after nodeplugin
restart. But due to a bug in NBD driver the writes are failing, please
note NBD zero cmd timeout handling is fixed with kernel >= 5.4 and hence
we should defend on writes based on kernel version to avoid unnecessary
CI failures.

For more information see
#2204 (comment)

updates: #2204
Signed-off-by: Prasanna Kumar Kalever prasanna.kalever@redhat.com


Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)
  • /retest all: run this in case the CentOS CI failed to start/report any test
    progress or results

@mergify mergify bot added the component/testing Additional test cases or CI work label Nov 9, 2021
@pkalever
Copy link
Author

pkalever commented Nov 9, 2021

@ceph/contributors there are two ways to address #2204:

  1. Should use the quiesce on signal mechanism rbd-nbd: add ability to quiesce on signal ceph#42609 with lower kernel versions (<5.4)
  2. Only support rbd-nbd on kernels >= 5.4

@pkalever pkalever changed the title e2e: restrict IO for lower version kernel at rbd-nbd tests e2e: restrict IO with lower version kernel at rbd-nbd tests Nov 9, 2021
e2e/rbd.go Show resolved Hide resolved
@pkalever
Copy link
Author

pkalever commented Nov 9, 2021

/retest ci/centos/mini-e2e/k8s-1.20

@nixpanic
Copy link
Member

/retest ci/centos/mini-e2e-helm/k8s-1.20

@nixpanic
Copy link
Member

/retest ci/centos/mini-e2e-helm/k8s-1.20

    Nov 10 06:19:54.151: failed to validate encrypted pvc with error timed out waiting for the condition

Failed with #2610

@nixpanic
Copy link
Member

@Mergifyio rebase

Currently, at "perform IO on rbd-nbd volume after nodeplugin restart"
test we are performing write on the rbd-nbd based mount after nodeplugin
restart. But due to a bug in NBD driver the writes are failing, please
note NBD zero cmd timeout handling is fixed with kernel >= 5.4 and hence
we should defend on writes based on kernel version to avoid unnecessary
CI failures.

For more information see
ceph#2204 (comment)

updates: ceph#2204
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
@mergify
Copy link
Contributor

mergify bot commented Nov 10, 2021

rebase

✅ Branch has been successfully rebased

@mergify mergify bot merged commit c97b643 into ceph:devel Nov 10, 2021
pkalever pushed a commit to pkalever/ceph-csi that referenced this pull request Nov 12, 2021
This got removed unintentionally with
ceph#2628

Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
pkalever pushed a commit to pkalever/ceph-csi that referenced this pull request Nov 14, 2021
This got removed unintentionally with
ceph#2628

Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
mergify bot pushed a commit that referenced this pull request Nov 16, 2021
This got removed unintentionally with
#2628

Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
mergify bot pushed a commit that referenced this pull request Nov 22, 2021
This got removed unintentionally with
#2628

Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
(cherry picked from commit cee6da5)

# Conflicts:
#	e2e/rbd.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/testing Additional test cases or CI work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants