-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rbac issue in rbd plugin #234
Conversation
remove unwanted rules and update rbac to have permission to modify endpoints and configmaps in the current namespace. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@@ -10,9 +10,6 @@ apiVersion: rbac.authorization.k8s.io/v1 | |||
metadata: | |||
name: rbd-external-attacher-runner | |||
rules: | |||
- apiGroups: [""] | |||
resources: ["events"] | |||
verbs: ["get", "list", "watch", "update"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verbs: ["list", "watch", "create", "update", "patch"] | ||
- apiGroups: [""] | ||
resources: ["endpoints"] | ||
verbs: ["get", "create", "update"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@rootfs done PTAL |
@Madhu-1 thanks, can you update these rbd in Rook as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but needs a helm version bump.
I get errors due to the removal of events from the provisioner. We're managing volumes outside of the namespace where the CSI components live. Is this something that should be added back for the provisioner?
|
Fixes: #ceph#234 (comment) Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Fixes: ##234 (comment) Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Fix rbac issue in rbd plugin
Fixes: #ceph#234 (comment) Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Syncing latest changes from release-v3.10 for ceph-csi
Fixes #218 (comment)
Fixes #218 (comment)
@rootfs @kfox1111 @gman0 PTAL