Fix rbac issue in rbd plugin #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove unwanted rules and update rbac to have permission to modify endpoints and configmaps in the current namespace. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
rootfs
reviewed
Feb 27, 2019
| @@ -10,9 +10,6 @@ apiVersion: rbac.authorization.k8s.io/v1 | |||
| metadata: | |||
| name: rbd-external-attacher-runner | |||
| rules: | |||
| - apiGroups: [""] | |||
| resources: ["events"] | |||
| verbs: ["get", "list", "watch", "update"] | |||
There was a problem hiding this comment.
rootfs
reviewed
Feb 27, 2019
| verbs: ["list", "watch", "create", "update", "patch"] | ||
| - apiGroups: [""] | ||
| resources: ["endpoints"] | ||
| verbs: ["get", "create", "update"] |
There was a problem hiding this comment.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
|
@rootfs done PTAL |
rootfs
approved these changes
Feb 27, 2019
|
@Madhu-1 thanks, can you update these rbd in Rook as well? |
kfox1111
reviewed
Feb 27, 2019
5 tasks
|
I get errors due to the removal of events from the provisioner. We're managing volumes outside of the namespace where the CSI components live. Is this something that should be added back for the provisioner? |
Madhu-1
added a commit
to Madhu-1/ceph-csi
that referenced
this pull request
Mar 4, 2019
Fixes: #ceph#234 (comment) Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
mergify bot
pushed a commit
that referenced
this pull request
Mar 4, 2019
Fixes: ##234 (comment) Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
wilmardo
pushed a commit
to wilmardo/ceph-csi
that referenced
this pull request
Jul 29, 2019
Fix rbac issue in rbd plugin
wilmardo
pushed a commit
to wilmardo/ceph-csi
that referenced
this pull request
Jul 29, 2019
Fixes: #ceph#234 (comment) Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
yati1998
pushed a commit
to yati1998/ceph-csi
that referenced
this pull request
Feb 20, 2024
Syncing latest changes from release-v3.10 for ceph-csi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #218 (comment)
Fixes #218 (comment)
@rootfs @kfox1111 @gman0 PTAL