Add support for cephfs helm chat #218

Madhu-1 · 2019-02-21T05:14:01Z

This PR adds the support for cephfs helm chat

logs

[🎩]mrajanna@localhost ceph-csi $]hlm install  --name "ceph-csi-cephfs" deploy/cephfs/helm/
NAME:   ceph-csi-cephfs
LAST DEPLOYED: Thu Feb 21 10:42:40 2019
NAMESPACE: default
STATUS: DEPLOYED

RESOURCES:
==> v1/ServiceAccount
NAME                         SECRETS  AGE
ceph-csi-cephfs-attacher     1        1s
ceph-csi-cephfs-nodeplugin   1        1s
ceph-csi-cephfs-provisioner  1        1s

==> v1/ClusterRole
NAME                         AGE
ceph-csi-cephfs-attacher     1s
ceph-csi-cephfs-nodeplugin   1s
ceph-csi-cephfs-provisioner  1s

==> v1/ClusterRoleBinding
NAME                         AGE
ceph-csi-cephfs-attacher     1s
ceph-csi-cephfs-nodeplugin   1s
ceph-csi-cephfs-provisioner  1s

==> v1/Service
NAME                         TYPE       CLUSTER-IP    EXTERNAL-IP  PORT(S)    AGE
ceph-csi-cephfs-attacher     ClusterIP  10.233.6.190  <none>       12345/TCP  1s
ceph-csi-cephfs-provisioner  ClusterIP  10.233.45.41  <none>       12345/TCP  1s

==> v1beta2/DaemonSet
NAME                        DESIRED  CURRENT  READY  UP-TO-DATE  AVAILABLE  NODE SELECTOR  AGE
ceph-csi-cephfs-nodeplugin  3        3        0      3           0          <none>         1s

==> v1beta1/StatefulSet
NAME                         DESIRED  CURRENT  AGE
ceph-csi-cephfs-attacher     1        1        1s
ceph-csi-cephfs-provisioner  1        1        1s

==> v1/Pod(related)
NAME                              READY  STATUS             RESTARTS  AGE
ceph-csi-cephfs-nodeplugin-7nhgw  0/2    ContainerCreating  0         0s
ceph-csi-cephfs-nodeplugin-bhtpw  0/2    ContainerCreating  0         1s
ceph-csi-cephfs-nodeplugin-x9jsw  0/2    ContainerCreating  0         0s
ceph-csi-cephfs-attacher-0        0/1    ContainerCreating  0         1s
ceph-csi-cephfs-provisioner-0     0/2    ContainerCreating  0         0s


NOTES:
Examples on how to configure a storage class and start using the driver are here:
https://github.com/ceph/ceph-csi/tree/csi-v1.0/examples/cephfs

[🎩︎]mrajanna@localhost ceph-csi $]kube get  po
NAME                               READY   STATUS    RESTARTS   AGE
ceph-csi-cephfs-attacher-0         1/1     Running   0          13s
ceph-csi-cephfs-nodeplugin-7nhgw   2/2     Running   0          12s
ceph-csi-cephfs-nodeplugin-bhtpw   2/2     Running   0          13s
ceph-csi-cephfs-nodeplugin-x9jsw   2/2     Running   0          12s
ceph-csi-cephfs-provisioner-0      2/2     Running   0          12s
[🎩︎]mrajanna@localhost ceph-csi $]hlm list
NAME           	REVISION	UPDATED                 	STATUS  	CHART                	APP VERSION	NAMESPACE
ceph-csi-cephfs	1       	Thu Feb 21 10:42:40 2019	DEPLOYED	ceph-csi-cephfs-0.4.0	1.0.0      	default  
[🎩︎]mrajanna@localhost ceph-csi $]hlm delete ceph-csi-cephfs
release "ceph-csi-cephfs" deleted

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

Madhu-1 · 2019-02-21T05:14:22Z

@rootfs @kfox1111 PTAL

Madhu-1 · 2019-02-21T05:17:19Z

@gman0 PTAL

kfox1111

All in all, this looks really good. Thanks for contributing it.

There are two files removed that I think you didn't intend to:
deploy/rbd/helm/templates/provisioner-role.yaml
deploy/rbd/helm/templates/provisioner-rolebinding.yaml

A few other comments inline

kfox1111 · 2019-02-21T17:10:38Z

deploy/rbd/helm/README.md


 ```bash
-helm install --namespace "ceph-csi-rbd" --name "ceph-csi-rbd" ceph-csi/ceph-csi-rbd
+helm install --name "ceph-csi-rbd" ceph-csi/ceph-csi-rbd


Why remove the namespace? This puts it in "default"

current templates in kubernetes folder deploy everything in the default namespace, to keep consistency between both I deleted helm deployment in a different namespace

I don't think installing it in "default" is a good recommendation for the users. Please undo.

kfox1111 · 2019-02-21T17:12:51Z

deploy/cephfs/helm/templates/nodeplugin-clusterrole.yaml

+    resources: ["volumeattachments"]
+    verbs: ["get", "list", "watch", "update"]
+  - apiGroups: [""]
+    resources: ["configmaps"]


Can you please double check the permssions for cephfs? rbd needs configmap reading, but I'm not sure cephfs does.

taken this from https://github.com/ceph/ceph-csi/blob/csi-v1.0/deploy/cephfs/kubernetes/csi-nodeplugin-rbac.yaml#L25-L27

Ok. I'll talk with rootfs about it. But I don't think that should block this pr.

Madhu-1 · 2019-02-21T18:56:05Z

All in all, this looks really good. Thanks for contributing it.

There are two files removed that I think you didn't intend to:
deploy/rbd/helm/templates/provisioner-role.yaml
deploy/rbd/helm/templates/provisioner-rolebinding.yaml

as we are creating cluster-role and binding cluster-role to a service-account, a normal role is not required, tested this and everything is working fine

kfox1111 · 2019-02-21T19:08:09Z

deploy/rbd/helm/templates/provisioner-role.yaml
deploy/rbd/helm/templates/provisioner-rolebinding.yaml

as we are creating cluster-role and binding cluster-role to a service-account, a normal role is not required, tested this and everything is working fine

You tested out the rbd driver without those two files and provisioning rbd volumes still worked?

Madhu-1 · 2019-02-22T04:45:43Z

deploy/rbd/helm/templates/provisioner-role.yaml
deploy/rbd/helm/templates/provisioner-rolebinding.yaml

as we are creating cluster-role and binding cluster-role to a service-account, a normal role is not required, tested this and everything is working fine

You tested out the rbd driver without those two files and provisioning rbd volumes still worked?

here are the logs

[🎩]mrajanna@localhost ceph-csi $]hlm install --namespace "ceph-csi-rbd" --name "ceph-csi-rbd" deploy/rbd/helm/
NAME:   ceph-csi-rbd
LAST DEPLOYED: Fri Feb 22 10:08:42 2019
NAMESPACE: ceph-csi-rbd
STATUS: DEPLOYED

RESOURCES:
==> v1beta1/StatefulSet
NAME                      DESIRED  CURRENT  AGE
ceph-csi-rbd-attacher     1        1        1s
ceph-csi-rbd-provisioner  1        1        1s

==> v1/Pod(related)
NAME                           READY  STATUS             RESTARTS  AGE
ceph-csi-rbd-nodeplugin-9jsfb  0/2    ContainerCreating  0         0s
ceph-csi-rbd-nodeplugin-rfsmp  0/2    ContainerCreating  0         0s
ceph-csi-rbd-nodeplugin-xbp9j  0/2    ContainerCreating  0         0s
ceph-csi-rbd-attacher-0        0/1    ContainerCreating  0         0s
ceph-csi-rbd-provisioner-0     0/3    ContainerCreating  0         0s

==> v1/ServiceAccount
NAME                      SECRETS  AGE
ceph-csi-rbd-attacher     1        1s
ceph-csi-rbd-nodeplugin   1        1s
ceph-csi-rbd-provisioner  1        1s

==> v1/ClusterRole
NAME                      AGE
ceph-csi-rbd-attacher     1s
ceph-csi-rbd-nodeplugin   1s
ceph-csi-rbd-provisioner  1s

==> v1/ClusterRoleBinding
NAME                      AGE
ceph-csi-rbd-attacher     1s
ceph-csi-rbd-nodeplugin   1s
ceph-csi-rbd-provisioner  1s

==> v1/Service
NAME                      TYPE       CLUSTER-IP    EXTERNAL-IP  PORT(S)    AGE
ceph-csi-rbd-attacher     ClusterIP  10.233.6.108  <none>       12345/TCP  1s
ceph-csi-rbd-provisioner  ClusterIP  10.233.43.73  <none>       12345/TCP  1s

==> v1beta2/DaemonSet
NAME                     DESIRED  CURRENT  READY  UP-TO-DATE  AVAILABLE  NODE SELECTOR  AGE
ceph-csi-rbd-nodeplugin  3        3        0      3           0          <none>         1s


NOTES:
Examples on how to configure a storage class and start using the driver are here:
https://github.com/ceph/ceph-csi/tree/csi-v1.0/examples/rbd


[🎩︎]mrajanna@localhost rbd $]kube get po -nceph-csi-rbd
NAME                            READY   STATUS    RESTARTS   AGE
ceph-csi-rbd-attacher-0         1/1     Running   0          5m5s
ceph-csi-rbd-nodeplugin-9jsfb   2/2     Running   1          5m5s
ceph-csi-rbd-nodeplugin-rfsmp   2/2     Running   1          5m5s
ceph-csi-rbd-nodeplugin-xbp9j   2/2     Running   1          5m5s
ceph-csi-rbd-provisioner-0      3/3     Running   0          5m5s
[🎩︎]mrajanna@localhost rbd $]kube get pvc
NAME      STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS   AGE
rbd-pvc   Bound    pvc-588b1039-365c-11e9-9088-5254003a618c   1Gi        RWO            csi-rbd        47s

kfox1111 · 2019-02-22T19:27:43Z

I think it will start, but it won't function properly without permissions to read/write the configmaps.

The rbd helm rbac is a little different then the static manifests. The security is tighter as it only has permissions to the configmaps in the specific namespace rather then for the entire cluster. Its a change I wouild like to propose to the static manifests too, but haven't had time yet.

Madhu-1 · 2019-02-25T06:42:31Z

I think it will start, but it won't function properly without permissions to read/write the configmaps.

means volume mount won't work as expected?

The rbd helm rbac is a little different then the static manifests. The security is tighter as it only has permissions to the configmaps in the specific namespace rather then for the entire cluster. Its a change I wouild like to propose to the static manifests too, but haven't had time yet.

i am not aware of this issue.

to make this PR completed, do i need to bring back deploy/rbd/helm/templates/provisioner-role.yaml deploy/rbd/helm/templates/provisioner-rolebinding.yaml files?

kfox1111 · 2019-02-25T15:47:10Z

Yeah, I don't think it will work properly to provision the volumes without the role.

I think it best if the PR only added the new chart, not touched the other chart. Its mergeable in its current state without the rbd changes.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

Madhu-1 · 2019-02-25T15:56:43Z

@kfox1111 reverted back the changes for role and role binding

kfox1111 · 2019-02-25T16:50:43Z

/lgtm

rootfs · 2019-02-25T17:33:28Z

thanks @kfox1111

Add support for cephfs helm chat

Syncing latest changes from upstream devel for ceph-csi

Madhu-1 added 3 commits February 21, 2019 10:38

Add helm chat for cephfs

27b46ab

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

update deploy.sh to push cephfs chat

50091ac

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

Fix formatting in helm rbd readme

3ac5af6

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

kfox1111 reviewed Feb 21, 2019

View reviewed changes

Madhu-1 force-pushed the cephfs-heml branch from e785f69 to 717571b Compare February 22, 2019 04:47

Madhu-1 added 2 commits February 25, 2019 21:24

update yamllint to ignore cephfs helm

b0c86df

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

update readme to deploy cephfs in namespace

55ad492

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

Madhu-1 force-pushed the cephfs-heml branch from 72e2054 to 55ad492 Compare February 25, 2019 15:55

rootfs approved these changes Feb 25, 2019

View reviewed changes

rootfs merged commit cb68b68 into ceph:csi-v1.0 Feb 25, 2019

Madhu-1 mentioned this pull request Feb 27, 2019

Fix rbac issue in rbd plugin #234

Merged

wilmardo pushed a commit to wilmardo/ceph-csi that referenced this pull request Jul 29, 2019

Merge pull request ceph#218 from Madhu-1/cephfs-heml

db3ea57

Add support for cephfs helm chat

nixpanic pushed a commit to nixpanic/ceph-csi that referenced this pull request Nov 22, 2023

Merge pull request ceph#218 from red-hat-storage/sync_us--devel

3896015

Syncing latest changes from upstream devel for ceph-csi

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for cephfs helm chat #218

Add support for cephfs helm chat #218

Madhu-1 commented Feb 21, 2019

Madhu-1 commented Feb 21, 2019

Madhu-1 commented Feb 21, 2019

kfox1111 left a comment

kfox1111 Feb 21, 2019

Madhu-1 Feb 21, 2019

kfox1111 Feb 21, 2019

Madhu-1 Feb 22, 2019

kfox1111 Feb 21, 2019

Madhu-1 Feb 21, 2019

kfox1111 Feb 21, 2019

Madhu-1 commented Feb 21, 2019

kfox1111 commented Feb 21, 2019

Madhu-1 commented Feb 22, 2019 •

edited

Loading

kfox1111 commented Feb 22, 2019

Madhu-1 commented Feb 25, 2019

kfox1111 commented Feb 25, 2019

Madhu-1 commented Feb 25, 2019

kfox1111 commented Feb 25, 2019

rootfs commented Feb 25, 2019

Add support for cephfs helm chat #218

Add support for cephfs helm chat #218

Conversation

Madhu-1 commented Feb 21, 2019

Madhu-1 commented Feb 21, 2019

Madhu-1 commented Feb 21, 2019

kfox1111 left a comment

Choose a reason for hiding this comment

kfox1111 Feb 21, 2019

Choose a reason for hiding this comment

Madhu-1 Feb 21, 2019

Choose a reason for hiding this comment

kfox1111 Feb 21, 2019

Choose a reason for hiding this comment

Madhu-1 Feb 22, 2019

Choose a reason for hiding this comment

kfox1111 Feb 21, 2019

Choose a reason for hiding this comment

Madhu-1 Feb 21, 2019

Choose a reason for hiding this comment

kfox1111 Feb 21, 2019

Choose a reason for hiding this comment

Madhu-1 commented Feb 21, 2019

kfox1111 commented Feb 21, 2019

Madhu-1 commented Feb 22, 2019 • edited Loading

kfox1111 commented Feb 22, 2019

Madhu-1 commented Feb 25, 2019

kfox1111 commented Feb 25, 2019

Madhu-1 commented Feb 25, 2019

kfox1111 commented Feb 25, 2019

rootfs commented Feb 25, 2019

Madhu-1 commented Feb 22, 2019 •

edited

Loading