Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Polkadot v0.9.24 #833

Merged
merged 13 commits into from
Jun 16, 2022
Merged

Update to Polkadot v0.9.24 #833

merged 13 commits into from
Jun 16, 2022

Conversation

NunoAlexandre
Copy link
Contributor

Forks used

  • NunoAlexandre/xcm-simulator pr
  • NunoAlexandre/open-runtime pr

Important changes

  • Move from jsonrpc to jsonrpsee which changes the way RPC apis/methods are built and composed
  • AccountIdConversion trait methods renames
  • pallet_uniques
    • tl;dr: "class" -> "collection", "instance" -> "item"
    • ❗ Api breaks (For frontend's special attention)
      • Anything "class" becomes "collection"
      • Anything "instance" becomes "item"

@NunoAlexandre NunoAlexandre mentioned this pull request Jun 15, 2022
Closed
@mikiquantum mikiquantum marked this pull request as ready for review June 15, 2022 23:45
mikiquantum
mikiquantum approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@mikiquantum mikiquantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few fixes and bumped the runtime versions, LGTM!

branan
branan approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@branan branan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all this looks good. The changes for the new substrate/polkadot version are all pretty clear and straightforward.

Let me know if there's any help I can provide getting the Pools RPCs back in place.

@mikiquantum mikiquantum merged commit 6cb6594 into parachain Jun 16, 2022
@NunoAlexandre NunoAlexandre mentioned this pull request Jun 18, 2022
Merged
@NunoAlexandre NunoAlexandre deleted the polkadot-v0.9.24 branch November 14, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@branan branan branan approved these changes

@mikiquantum mikiquantum mikiquantum approved these changes

Assignees

@NunoAlexandre NunoAlexandre

@mikiquantum mikiquantum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NunoAlexandre @branan @mikiquantum