Additional RPC-Methods and Runtime-Apis #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have not yet tested the rpc endpoints with a local chain. Thought, this would be the easiest I can close and be off help. |
hieronx
reviewed
Apr 27, 2022
|
Rpc endpoints seem to work. But apps should dedicatedly test this. |
|
The node currently panics when calling |
hieronx
reviewed
May 24, 2022
|
@offerijns addressed your feedback. I left the mapping of |
…chain into feature/rpc-extensions
Consumers of the API should always use an Id, never an index. Indexes may change underneat an API consumer at any block if the tranches change, while Ids are stable. This change enforces that correctness, and simplifies client code which no longer needs to wrap Ids in Locs
This is panicking for unknown reasons and can easily be computed on the client instead. We're giving up on it for now ¯\_(ツ)_/¯
* Remove unused `pool_value` from Runtime API * Remove `pool_` prefix, as it is redundant at the RPC level
branan
force-pushed
the
feature/rpc-extensions
branch
from
48ecec2
to
4ae7f82
Compare
added 2 commits
May 31, 2022 18:05
These aren't totally working and aren't needed for the first release
hieronx
approved these changes
Jun 1, 2022
NunoAlexandre
added a commit
that referenced
this pull request
Jun 15, 2022
This reverts commit 7cb6dba.
mikiquantum
added a commit
that referenced
this pull request
Jun 16, 2022
* Revert "Additional RPC-Methods and Runtime-Apis (#796)" This reverts commit 7cb6dba. * wip: Update to v0.9.22 * wip * make rpc_ext_builder compile with todo * wip: Migrate api.rs to jsonrpsee * Migrate api.rs/AnchorApi to jsonrpsee Some new dark magic. * docker: bump polkadot images to v0.9.22 * Update to polkadot v0.9.23 * Update to polkadot-v0.9.24 * Bump docker images to 0.9.24 * fmt * Update rust toolchain to 1.62.0 / nightly-2022-05-09 * various fixes Co-authored-by: Miguel Hervas <miguel.hervas.lazaro@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements some needed runtime-apis and corresponding rpc-methods.
Closes #747
Closes #749
Closes #748