-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loans: maturity extension support #1445
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
e1ebe46
add fields
lemunozm b3811cf
loan repayment schema
lemunozm 4bb2f5f
external pricing with interest
lemunozm 3a87f75
add type for active interest rates
lemunozm a9ed030
pricing based on interest rate module
lemunozm 4c291ce
minor changes
lemunozm d06e00d
update diagram with max borrow amount
lemunozm e141eb5
update diagram with PR changes
lemunozm fd8d54f
minor method renamed
lemunozm 2e157b7
rename normalized_debt field
lemunozm 211b496
Merge remote-tracking branch 'origin/main' into loans/principal-and-i…
lemunozm 949449d
rename interest_rate to interest
lemunozm ecec980
legacy tests passing
lemunozm 039c27c
add new tests for external interest
lemunozm 7f0ced0
support interest rate mutation for external pricing
lemunozm 751e44a
fix benchmarks
lemunozm 8414469
Merge remote-tracking branch 'origin/main' into loans/principal-and-i…
lemunozm 28c06b3
rename unchecked to unscheduled amount
lemunozm c7f48c6
update diagram with RepaidAmount
lemunozm 7d3ed49
fix integration tests
lemunozm 69a7e5d
minor diagram layout change
lemunozm 1790e88
fix runtime common issue
lemunozm 6a51a73
fix integration tests
lemunozm 9a8c3bf
Merge remote-tracking branch 'origin/main' into loans/principal-and-i…
lemunozm f73f81c
add missing docs
lemunozm c118db5
remove Once part from RepayRestriction::FullOnce
lemunozm 9707d06
Merge remote-tracking branch 'origin/main' into loans/principal-and-i…
lemunozm 65987dd
add maturity extension support
lemunozm 2a2961c
fix integration-tests
lemunozm 2f26a68
add tests for wrong mutations
lemunozm c13ca10
Merge remote-tracking branch 'origin/main' into loans/maturity-extension
lemunozm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the migration. But it needs migration "theoretically". Right now we can purge all
pallet-loans
storage. It only requires a migration if it is used before we can deploy these changes. The same applies to all pending PRsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, I read you wrong 😆, I pointed to the code that causes the migration. No, there is no migration done, but should not be done by now