-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loans: maturity extension support #1445
Conversation
I've rebased this already approved by Jeroen, it would be awesome if you could give a re-approve it @mustermeiszer 🙌🏻 |
@lemunozm does this need a migration? Because I can not spot the migration code ^^ Just am worried we forget about it if we add it later. |
Fixed { | ||
/// Secs when maturity ends | ||
date: Moment, | ||
/// Extension in secs, without special permissions | ||
extension: Moment, | ||
}, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the migration. But it needs migration "theoretically". Right now we can purge all pallet-loans
storage. It only requires a migration if it is used before we can deploy these changes. The same applies to all pending PRs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, I read you wrong 😆, I pointed to the code that causes the migration. No, there is no migration done, but should not be done by now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Fixes #1405
Changes and Descriptions
extension
field toMaturity::Fixed
MaturityExtension