Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3 vs 4 diff #211

Open
wants to merge 4 commits into
base: releases/3
Choose a base branch
from
Open

Release 3 vs 4 diff #211

wants to merge 4 commits into from

Conversation

pahor167
Copy link
Contributor

@pahor167 pahor167 commented Nov 6, 2024

Description

A few sentences describing the overall effects and goals of the pull request's commits.
What is the current behavior, and what is the updated/expected behavior with this PR?

Other changes

Describe any minor or "drive-by" changes here.

Tested

An explanation of how the changes were tested or an explanation as to why they don't need to be.

Related issues

  • Fixes #[issue number here]

soloseng and others added 4 commits May 13, 2024 09:57
* updated the proposal expiration logic (#196)

* performed check on from group balance (#197)

* removed unused error (#198)

* Soloseng/audit-fix-clst-1 (#199)

* performed check on from group balance

* switch getCeloForGroup to public function

* Alfajores release 3 (#200)

* alfajores contract release

* updated deployed contract abis

* Updated deploy script to use existing libraby

* - updated DefaultStrategy main ABI
- Removed unused solc input

* tooling to generate MultiSig proposal payload for v3 contract upgrade

* ++ multisig edge case test

* hardcoded multisig signer address

* Soloseng/mainnet-release-3 (#201)

* updated to fix local testing that deploy a new contract instance

* updated test as `scheduleTransfer()` no longer allows transfers when `celoAvailableForGroup` is too low

* only set multisig impersonator when needed
* ChangeStrategy update

* test fix
* When health changes update

* lint

* test fix

* test fix

* update default strategy

* changeStrategy force

* version updates

* manager version

* version update

* manager version ?

* Update contracts/Manager.sol

Co-authored-by: soloseng <102702451+soloseng@users.noreply.github.com>

* Update contracts/Manager.sol

Co-authored-by: soloseng <102702451+soloseng@users.noreply.github.com>

* Update contracts/Manager.sol

Co-authored-by: soloseng <102702451+soloseng@users.noreply.github.com>

* PR comments

* build fix

* removal of todo

---------

Co-authored-by: soloseng <102702451+soloseng@users.noreply.github.com>
Copy link

Release 3 vs 4 diff

Generated at commit: a3c350a23ed3aade246a2bb0a93ec53a7607a5be

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
3
0
8
27
40
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants