Updated the proposal expiration logic #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the proposal expiration logic
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Closed
pahor167
approved these changes
Apr 2, 2024
soloseng
added a commit
that referenced
this pull request
May 13, 2024
* updated the proposal expiration logic (#196) * performed check on from group balance (#197) * removed unused error (#198) * Soloseng/audit-fix-clst-1 (#199) * performed check on from group balance * switch getCeloForGroup to public function * Alfajores release 3 (#200) * alfajores contract release * updated deployed contract abis * Updated deploy script to use existing libraby * - updated DefaultStrategy main ABI - Removed unused solc input * tooling to generate MultiSig proposal payload for v3 contract upgrade * ++ multisig edge case test * hardcoded multisig signer address * Soloseng/mainnet-release-3 (#201) * updated to fix local testing that deploy a new contract instance * updated test as `scheduleTransfer()` no longer allows transfers when `celoAvailableForGroup` is too low * only set multisig impersonator when needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressed issues highlited by CLST-5