Computing uptimes if they are not up to date #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevjue
reviewed
Jun 19, 2020
kevjue
reviewed
Jun 19, 2020
mcortesi
reviewed
Jun 23, 2020
mrsmkl
force-pushed
the
mrsmkl/fastsync-fix
branch
from
f90f389 to
c7e36d7
Compare
mcortesi
reviewed
Jul 1, 2020
mcortesi
approved these changes
Jul 2, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running fast sync, the uptimes aren't updated (except for some number of blocks at the end of fast sync)
Other changes
Tested
Fast sync with baklava worked, next going to sync with mainnet.
Related issues
Backwards compatibility
Yes.