Disables fast sync #1041
Closed
Disables fast sync #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is unrelated to #1022, it has been around for a while. Can we bisect the commit history and find when this first started happening? |
|
I suspect this is here for a long time... To clarify further, this happens
even on the RC1 docket imagem
The problem is that currently it takes a long time to reproduce - you need
a fast sync node that is already synced, and them stumble upon an epoch
block. I'm guessing we can probably reproduce it with a test chain.
…On Tue, May 19, 2020, 10:38 Georgios Konstantopoulos < ***@***.***> wrote:
This is unrelated to #1022
<#1022>, it has been
around for a while. Can we bisect the commit history and find when this
first started happening?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1041 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA23MGFXD5B3TBO2KAUJ2KLRSIZP5ANCNFSM4NEIU4QA>
.
|
asaj
approved these changes
Jun 1, 2020
Closed
|
It looks like #1081 has fixed fast sync, so this PR is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems a few people have stumbled upon BAD BLOCK situations when using fast sync. I've verified that running a fast synced node starts failing on an epoch block on RC1. I think it's best we disable it until we investigate it further.