Add minClientVersion 4.0.0, used by vs2017 #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks 👍 Do you have a reference link/supporting article? I haven't had a chance to look into this, link for confirmation would be nice. Thanks |
|
Sure, the first message here: NuGet/Home#4492 |
|
Great, thanks. |
|
Console.WriteLine("牛逼！"); |
amaitland
added a commit
that referenced
this pull request
Jan 14, 2020
…k.redist.win-x64 packages (#83) * Experimental - New runtimes\native nuget packages * Initial chromiumembeddedframework.redist.win.nuspec * Makes it clearer it's the chromium embedded framework, also makes it easier to distinguish between old and new when working on the code * Add minClientVersion 4.0.0, used by vs2017 (#84) * Nupkg - Include ContentFiles for swiftshader and locales - Upgrade nuget.exe to version 5.4 (was previously 2.8) - Add new logo (converted existing gif to png), the logo is now included in the package - Rename props files as they didn't match the new naming convention - Add contentFiles metadata element - Copy swiftshader/locales into the runtimes\win-x64\native folder so they're relative to libcef.dll NOTE: Only minimal testing so far, loaded into a .Net Core 3 MinimalExample solution, files are copied as expected. The swiftshader and locales folders aren't in the runtimeconfig.json TODO: - Try installing both x86 and x64 into same project. - Test with just having a .Net 4.8 PackageReference project References: https://docs.microsoft.com/en-us/nuget/reference/nuspec#specifying-files-to-include-in-the-package https://devblogs.microsoft.com/nuget/nuget-contentfiles-demystified/ https://stackoverflow.com/questions/56844233/additional-probing-paths-for-net-core-3-migration * cef.redist.win-x64/x86.props - Add props for swiftshader and locales Swiftshader and locales are in the contentFiles folder so we need to include individual props (They could technically be compiled into a single prop, have separate for now) Co-authored-by: Matthias Hoste <42743095+lifecoder-phoenix@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement to #83