Add chromiumembeddedframework.redist.win-x86/chromiumembeddedframework.redist.win-x64 packages #83
Conversation
|
swiftshader and locales folders need to be moved to |
- Upgrade nuget.exe to version 5.4 (was previously 2.8) - Add new logo (converted existing gif to png), the logo is now included in the package - Rename props files as they didn't match the new naming convention - Add contentFiles metadata element - Copy swiftshader/locales into the runtimes\win-x64\native folder so they're relative to libcef.dll NOTE: Only minimal testing so far, loaded into a .Net Core 3 MinimalExample solution, files are copied as expected. The swiftshader and locales folders aren't in the runtimeconfig.json TODO: - Try installing both x86 and x64 into same project. - Test with just having a .Net 4.8 PackageReference project References: https://docs.microsoft.com/en-us/nuget/reference/nuspec#specifying-files-to-include-in-the-package https://devblogs.microsoft.com/nuget/nuget-contentfiles-demystified/ https://stackoverflow.com/questions/56844233/additional-probing-paths-for-net-core-3-migration
Swiftshader and locales are in the contentFiles folder so we need to include individual props (They could technically be compiled into a single prop, have separate for now)
Makes it clearer it's the chromium embedded framework, also makes it easier to distinguish between old and new when working on the code
amaitland
changed the title
|
NuGet package - Selenium WebDriver ChromeDriver takes a old school approach, using a complex targets file to copy files, we might need something like this for |
There is no |
|
First draft is hopefully complete, will merge this now so the next set of packages include the two new Further changes will likely be required. Looking at the documentation this is likely the easy part, the managed packages will be much more complex. It's still yet to be seen if |
New set of modern
Nugetpackages, see cefsharp/CefSharp#2795 for more details.Not ready for merge yet.
minClientVersionto ensure can only be used inVS2017/2019swiftshaderand locales folders usingcontentFilesAnyCPU[ ] Support(NoWin32target used byVC++ projects(x86might may automatically, haven't checked, testing required).Win32entry in theRid Catalog)