-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Implement Change Preferences at Runtime. #1444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@myrnazhou FYI a way for us to change spelling on the fly in the near future. |
@Bodekaer cool (y) |
f20180b
to
249ea57
Compare
Basic implementation should be complete. @Bodekaer @myrnazhou If either if you have time to take this for a spin that would be greatly appreciated 👍 |
It's probably worth creating an |
GetAllPreferences returns null. I'd test if GetPreference/SetPreference works but I don't know preference names. Hmm maybe I use it wrong? (It's the latest commit from your fork/pull request)
Also don't forget to wrap GetDefaultCookieManager :) |
From what I can gather you have to wait for the browser to have initialized before you can call
@midas643 I don't have any more time to work on this as the moment. Please submit a |
@amaitland Thanks so much. I've used GetAllPreferences after initialization and it works. Preferences: I will surely submit a PR when I find time. After I test setting/getting I will post some examples here. |
@midas643 Excellent news 👍 Any luck with setting a preference? Anyone have a suggestion on how to wrap things in a nicer way? |
Haven't yet implemented the GetAllPreferences as yet.
…eference key can have a dictionary of values as it's child. For instance webgl may have a number of sub preferences. Allow for returning of a dictionary when returning a specific preference Having some compiler problems with setting of dictionary values
249ea57
to
9b5a040
Compare
Can now access the RequestContext through IBrowserHost (can get access to the global context if required now)
9b5a040
to
dc121af
Compare
I've rebased this Merging this into |
Implement Change Preferences at Runtime.
Add new Get/Set preference methods to the RequestContext
Implementation is not quite complete yet.