Skip to content

chore(fixtures): sync test-project-live and -pnpm with strict test-project - #2997

Draft
Tobbe wants to merge 1 commit into
mainfrom
tobbe-strict-fixture-sync
Draft

Tobbe wants to merge 1 commit into
mainfrom
tobbe-strict-fixture-sync

Conversation

@Tobbe

@Tobbe Tobbe commented Oct 11, 2026

Copy link
Copy Markdown
Member

Summary

__fixtures__/test-project-live and __fixtures__/test-project-pnpm get the same changes that #2993 makes to __fixtures__/test-project:

  • strict in the api, web, scripts and packages/validators tsconfigs
  • the strict-clean generator output (services, scaffold forms and edit cells, formatters, dbAuth function)
  • the test-project page and story changes (ContactUs, Profile, BlogPost and Waterfall stories)

These two fixtures are copies of test-project that are updated by hand. No CI job regenerates them.

The BlogPost and Waterfall stories in __fixtures__/fragment-test-project spread {...args} before id, matching the other fixtures. Nothing type-checks that fixture; it's only read by packages/internal's possibleTypes test.

This is one of the PRs split out of #2993 (it was too big for a full review). Merge it after #2993 and #2995, since the strict tsconfigs rely on the types and generator output from those PRs. It's a draft until then.

Testing

The changes match the __fixtures__/test-project diff in #2993, file for file. CI on this PR runs the live and pnpm smoke tests against these fixtures.

@netlify

netlify Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for cedarjs canceled.

Name Link
🔨 Latest commit 7244f62
🔍 Latest deploy log https://app.netlify.com/projects/cedarjs/deploys/6acb60eca2618e0008ce9886

@coderabbitai

coderabbitai Bot commented Oct 11, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 7244f62

Command Status Duration Result
nx run-many -t build:pack --exclude create-ceda... ✅ Succeeded 5s View ↗
nx run-many -t test --maxWorkers=4 ✅ Succeeded <1s View ↗
nx run-many -t test:types ✅ Succeeded 13s View ↗
nx run-many -t build --output-style=stream ✅ Succeeded 5s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-10-11 10:25:14 UTC

@github-actions github-actions Bot added this to the chore milestone Oct 11, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant