Repository navigation
Conversation
✅ Deploy Preview for cedarjs canceled.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Tobbe
added a commit
that referenced
this pull request
Oct 11, 2026
|
View your CI Pipeline Execution ↗ for commit 7244f62
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__fixtures__/test-project-liveand__fixtures__/test-project-pnpmget the same changes that #2993 makes to__fixtures__/test-project:strictin the api, web, scripts andpackages/validatorstsconfigsThese two fixtures are copies of
test-projectthat are updated by hand. No CI job regenerates them.The BlogPost and Waterfall stories in
__fixtures__/fragment-test-projectspread{...args}beforeid, matching the other fixtures. Nothing type-checks that fixture; it's only read bypackages/internal'spossibleTypestest.This is one of the PRs split out of #2993 (it was too big for a full review). Merge it after #2993 and #2995, since the strict tsconfigs rely on the types and generator output from those PRs. It's a draft until then.
Testing
The changes match the
__fixtures__/test-projectdiff in #2993, file for file. CI on this PR runs the live and pnpm smoke tests against these fixtures.