Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): namespace, version and repo extracted to dedicated properties #947

Merged
merged 4 commits into from
Dec 28, 2022

Conversation

yfried
Copy link
Contributor

@yfried yfried commented Dec 25, 2022

Fixes #940

Signed-off-by: Yair Fried 5310525+yfried@users.noreply.github.com

Fixes: cdk8s-team#940

Signed-off-by: Yair Fried <5310525+yfried@users.noreply.github.com>
@yfried yfried changed the title Adds namespace,version,repo to Helm (feat): Adds namespace,version,repo to Helm Dec 25, 2022
@yfried yfried changed the title (feat): Adds namespace,version,repo to Helm feat: Adds namespace,version,repo to Helm Dec 25, 2022
@yfried yfried changed the title feat: Adds namespace,version,repo to Helm feat(helm): Adds namespace,version,repo Dec 25, 2022
@iliapolo iliapolo changed the title feat(helm): Adds namespace,version,repo feat(helm): namespace, version and repo extracted to dedicated properties Dec 28, 2022
@iliapolo iliapolo added the backport-to-1.x Backport a PR to the 1.x branch label Dec 28, 2022
Signed-off-by: Yair Fried <5310525+yfried@users.noreply.github.com>
…elm_version_etc

Signed-off-by: Yair Fried <5310525+yfried@users.noreply.github.com>
@mergify mergify bot merged commit 4436532 into cdk8s-team:2.x Dec 28, 2022
cdk8s-automation pushed a commit that referenced this pull request Dec 28, 2022
…properties (#947)

Fixes #940

Signed-off-by: Yair Fried <5310525+yfried@users.noreply.github.com>
(cherry picked from commit 4436532)
Signed-off-by: Yair Fried <5310525+yfried@users.noreply.github.com>
@cdk8s-automation
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
1.x

Questions ?

Please refer to the Backport tool documentation

mergify bot pushed a commit that referenced this pull request Dec 28, 2022
…properties (#947) (#953)

# Backport

This will backport the following commits from `2.x` to `1.x`:
 - [feat(helm): `namespace`, `version` and `repo` extracted to dedicated properties (#947)](#947)



### Questions ?
Please refer to the [Backport tool documentation](https://github.com/sqren/backport)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-1.x Backport a PR to the 1.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart should expose some common properties to reduce usage of helmFlags
3 participants