Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm chart should expose some common properties to reduce usage of helmFlags #940

Closed
yfried opened this issue Dec 22, 2022 · 0 comments · Fixed by #947
Closed

Helm chart should expose some common properties to reduce usage of helmFlags #940

yfried opened this issue Dec 22, 2022 · 0 comments · Fixed by #947
Labels
effort/small 1 day tops feature-request New/Enhanced functionality wanted priority/p1 Should be on near term plans

Comments

@yfried
Copy link
Contributor

yfried commented Dec 22, 2022

the following properties can be passed to helm template but are essential to the chart usage and should be exposed as attributes:

  • repo - url of the repository (replace the need to do helm repo add prior to the run)
  • version - the chart version
  • namespace - sometimes the helm release needs to go to its own namespace
yfried added a commit to yfried/cdk8s-core that referenced this issue Dec 25, 2022
@yfried
Adds namespace,version,repo to Helm
7b3a42a 
Fixes: cdk8s-team#940

Signed-off-by: Yair Fried <5310525+yfried@users.noreply.github.com>
@yfried yfried mentioned this issue Dec 25, 2022
Merged
@iliapolo iliapolo added feature-request New/Enhanced functionality wanted effort/small 1 day tops priority/p1 Should be on near term plans labels Dec 28, 2022
@mergify mergify bot closed this as completed in #947 Dec 28, 2022
mergify bot pushed a commit that referenced this issue Dec 28, 2022
@yfried
feat(helm): namespace, version and repo extracted to dedicated …
4436532 
…properties (#947)

Fixes #940

Signed-off-by: Yair Fried <5310525+yfried@users.noreply.github.com>
cdk8s-automation pushed a commit that referenced this issue Dec 28, 2022
@yfried
feat(helm): namespace, version and repo extracted to dedicated …
d524dca 
…properties (#947)

Fixes #940

Signed-off-by: Yair Fried <5310525+yfried@users.noreply.github.com>
(cherry picked from commit 4436532)
Signed-off-by: Yair Fried <5310525+yfried@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/small 1 day tops feature-request New/Enhanced functionality wanted priority/p1 Should be on near term plans
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(helm): namespace, version and repo extracted to dedicated properties yfried/cdk8s-core
2 participants
@iliapolo @yfried