Skip to content

Conversation

@dereklwood
Copy link
Contributor

This removes the duplication of the hdp "build number" attributes, and instead only ever gets the build number via the hdp_version helper library.

  • in the attributes, it uses a ruby %{} delayed interpolation token
  • in the default recipe, it interpolates it, with a value of a call to the hdp_version helper library
  • added a test for it

Copy link
Contributor

@wolf31o2 wolf31o2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. That was one pain point that made the cookbook ugly.

@dereklwood
Copy link
Contributor Author

:)

@dereklwood dereklwood merged commit 179c455 into master Sep 5, 2017
@dereklwood dereklwood deleted the feature/remove-hdp-version-attrs branch September 12, 2017 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants