use hadoop helper library to evaluate hdp build number #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dereklwood
force-pushed
the
feature/delayed-attrs
branch
from
34cc656 to
65fc3eb
Compare
|
travis failures are dependency ruby/chef compatability related. I plan to update this cookbook to the docker-based framework used in the |
mattwuenschel
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR removes the need to maintain the list of HDP build numbers, duplicated from the
hadoopcookbook. It uses delayed interpolation to evaluate the attributes at runtime, calling thehadooplibrary helper itself. This is very similar to cdapio/hadoop_cookbook#344, in which the same mechanism was introduced to remove duplicity within thehadoopcookbook itself.