Skip to content

Conversation

@FeldmeierMichael
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v21.1.8) reports: 9 concern(s)
  • init.cpp:20:34: warning: [misc-unused-parameters]

    parameter 'pAbc' is unused

       20 | int PexactCommand( Abc_Frame_t * pAbc, int argc, char ** argv )
          |                                  ^~~~
          |                                   /*pAbc*/
  • init.cpp:37:28: warning: [cert-err34-c]

    'atoi' used to convert a string to an integer value, but function will not report conversion errors; consider using 'strtol' instead

       37 |             pPars->nVars = atoi( argv[globalUtilOptind] );
          |                            ^
  • init.cpp:40:9: warning: [bugprone-branch-clone]

    switch has 2 consecutive identical branches

       40 |         case 'h':
          |         ^
    /home/runner/work/ext-pexact/ext-pexact/abc/src/ext-pexact/init.cpp:43:23: note: last of these clones ends here
       43 |             goto usage;
          |                       ^
  • init.cpp:69:57: warning: [performance-avoid-endl]

    do not use 'std::endl' with streams; use '\n' instead

       69 |     std::cout << "Number of Inputs:" << pPars->nVars << std::endl;
          |                                                         ^~~~~~~~~
          |                                                         '\n'
  • init.cpp:79:6: warning: [readability-identifier-naming]

    invalid case style for function 'init'

       79 | void init( Abc_Frame_t * pAbc )
          |      ^~~~
          |      Init
       80 | {
       81 |     Cmd_CommandAdd( pAbc, "pexact", "pexact", PexactCommand, 0 );
       82 | }
       83 | 
       84 | // called during ABC termination
       85 | void destroy( Abc_Frame_t * pAbc )
       86 | {
       87 | }
       88 | 
       89 | // this object should not be modified after the call to Abc_FrameAddInitializer
       90 | Abc_FrameInitializer_t frame_initializer = { init, destroy };
          |                                              ~~~~
          |                                              Init
  • init.cpp:85:6: warning: [readability-identifier-naming]

    invalid case style for function 'destroy'

       85 | void destroy( Abc_Frame_t * pAbc )
          |      ^~~~~~~
          |      Destroy
       86 | {
       87 | }
       88 | 
       89 | // this object should not be modified after the call to Abc_FrameAddInitializer
       90 | Abc_FrameInitializer_t frame_initializer = { init, destroy };
          |                                                    ~~~~~~~
          |                                                    Destroy
  • init.cpp:90:24: warning: [readability-identifier-naming]

    invalid case style for global variable 'frame_initializer'

       90 | Abc_FrameInitializer_t frame_initializer = { init, destroy };
          |                        ^~~~~~~~~~~~~~~~~
          |                        s_frame_initializer
       91 | 
       92 | // register the initializer a constructor of a global object
       93 | // called before main (and ABC startup)
       94 | struct registrar {
       95 |     registrar()
       96 |     {
       97 |         Abc_FrameAddInitializer( &frame_initializer );
          |                                   ~~~~~~~~~~~~~~~~~
          |                                   s_frame_initializer
  • init.cpp:94:8: warning: [readability-identifier-naming]

    invalid case style for struct 'registrar'

       94 | struct registrar {
          |        ^~~~~~~~~
          |        Registrar_t_
       95 |     registrar()
          |     ~~~~~~~~~
          |     Registrar_t_
  • init.cpp:99:3: warning: [readability-identifier-naming]

    invalid case style for global variable 'pexact_registrar'

       99 | } pexact_registrar;
          |   ^~~~~~~~~~~~~~~~
          |   s_pexact_registrar

Have any feedback or feature suggestions? Share it here.

@FeldmeierMichael FeldmeierMichael changed the title Added Command Usage Message for "exact" Added Command Usage Message for "pexact" Dec 4, 2025
FeldmeierMichael added a commit that referenced this pull request Dec 8, 2025
FeldmeierMichael added a commit that referenced this pull request Dec 11, 2025
FeldmeierMichael added a commit that referenced this pull request Dec 11, 2025
marcelwa added a commit that referenced this pull request Dec 16, 2025
* 🔧Fixed Typo

* 💄Added basic exact Encoding

* 💄Added basic exact Encoding

* 🔧fixed Clang-Tidy Warnings #1

* 🔧Fixed Clang-Tidy Warnings #2

* 🔧Fixed Clang-Tidy Warnings #3

* 🔧Fixed Clang-Tidy Warnings #4

* 🔧Fixed Clang-Tidy Warnings #5

* 🔧Fixed Clang-Tidy Warnings #6

* 🔧Fixed Clang-Tidy Warnings #7

* 🔧Fixed Clang-Tidy Warnings #8

* 🔧Fixed Clang-Tidy Warnings #9

* 🔧Fixed Clang-Tidy Warnings #10

* 🔧Fixed Clang-Tidy Warnings #11

* 🔧Fixed Clang-Tidy Warnings #12

* 🔧Fixed Clang-Tidy Warnings #13

* 🔧Fixed Clang-Tidy Warnings #14

* 🔧Fixed Clang-Tidy Warnings #15

* 🔧Fixed Clang-Tidy Warnings #15

* 🔧Fixed Clang-Tidy Warnings #17

* 🔧Fixed Clang-Tidy Warnings #18

* 🔧Fixed Clang-Tidy Warnings #19

* @FeldmeierMichael
🔧Fixed Clang-Tidy Warnings #20

* 🔧Fixed Clang-Tidy Warnings #20

* 🔧Fixed Clang-Tidy Warnings #21

* 🔧Fixed Clang-Tidy Warnings #22

* 🔧Fixed Clang-Tidy Warnings #23

* 🔧Fixed Clang-Tidy Warnings #24

* 💬Added Comments

* 🎨Incooperating AI Feedback

* 🔧Fixed Clang-Tidy Warnings #25

* 🎨Incooperating AI Feedback #2

* 🔧Fixed Clang-Tidy Warnings #26

* 🔨Added CodeRabbit Feedback

* 🔧Fixed Clang-Tidy Warnings #27

* 🔧Fixed Clang-Tidy Warnings #27

* 🔧Fixed Clang-Tidy Warnings #28

* 🔧Fixed Clang-Tidy Warnings #29

* 🔧Fixed Clang-Tidy Warnings #30

* 🔧Fixed Clang-Tidy Warnings #31

* 🔧Fixed Clang-Tidy Warnings [#32]

* 🔧Fixed Clang-Tidy Warnings #32

* 🔧Fixed Clang-Tidy Warnings #32

* 🔧Fixed Clang-Tidy Warnings #32

* 🔧Fixed Clang-Tidy Warnings #33

* 🔧Fixed Clang-Tidy Warnings #33

* 🔧Fixed Clang-Tidy Warnings #34

* 🔧Fixed Clang-Tidy Warnings #35

* 🎨Incooperating AI Feedback #3

* 🔧Fixed Clang-Tidy Warnings #36

* 🎨Incooperating AI Feedback #4

* 🔧Fixed Clang-Tidy Warnings #37

* 🔧Fixed Clang-Tidy Warnings #38

* 🎨Incooperating AI Feedback #4

* 🚑 Integrating reviewer feedback

* 🔧Fixed Clang-Tidy Warnings #39

* 🎨Incooperating AI Feedback #5

* 🔧Fixed Clang-Tidy Warnings #40

* 🔧Fixed Clang-Tidy Warnings #41

* 🎨Incooperating AI Feedback #6

* 🎨Incooperating AI Feedback #7

* 🔧Fixed Clang-Tidy Warnings #42

* 🎨Incooperating AI Feedback #8

* 🔧Fixed Clang-Tidy Warnings #43

* 🔧Fixed Clang-Tidy Warnings #44

* 🔧Fixed Clang-Tidy Warnings #45

* ✏️ Fix typo

---------

Co-authored-by: Marcel Walter <marcel.walter@tum.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants