💬 Added Command Usage Message

[FeldmeierMichael]

Added Command Usage Message to Command "pexact"

[github-actions]

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v21.1.8) reports: 15 concern(s)

• init.cpp:20:5: warning: [readability-identifier-naming]

  invalid case style for function 'Pexact_Command'

     20 | int Pexact_Command( Abc_Frame_t * pAbc, int argc, char ** argv )
        |     ^~~~~~~~~~~~~~
        |     PexactCommand

• init.cpp:20:35: warning: [misc-unused-parameters]

  parameter 'pAbc' is unused

     20 | int Pexact_Command( Abc_Frame_t * pAbc, int argc, char ** argv )
        |                                   ^~~~
        |                                    /*pAbc*/

• init.cpp:23:5: warning: [readability-isolate-declaration]

  multiple declarations in a single statement reduces readability

     23 |     Bmc_EsPar_t Pars, *pPars = &Pars;
        |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

• init.cpp:23:17: warning: [readability-identifier-naming]

  invalid case style for local variable 'Pars'

     23 |     Bmc_EsPar_t Pars, *pPars = &Pars;
        |                 ^
  note: this fix will not be applied because it overlaps with another fix

• init.cpp:36:28: warning: [cert-err34-c]

  'atoi' used to convert a string to an integer value, but function will not report conversion errors; consider using 'strtol' instead

     36 |             pPars->nVars = atoi( argv[globalUtilOptind] );
        |                            ^

• init.cpp:38:36: warning: [readability-braces-around-statements]

  statement should be inside braces

     38 |             if ( pPars->nVars < 0 )
        |                                    ^
        |                                     {
     39 |                 goto usage;
        |                            

• init.cpp:47:29: warning: [cert-err34-c]

  'atoi' used to convert a string to an integer value, but function will not report conversion errors; consider using 'strtol' instead

     47 |             pPars->nNodes = atoi( argv[globalUtilOptind] );
        |                             ^

• init.cpp:49:37: warning: [readability-braces-around-statements]

  statement should be inside braces

     49 |             if ( pPars->nNodes < 0 )
        |                                     ^
        |                                      {
     50 |                 goto usage;
        |                            

• init.cpp:52:9: warning: [bugprone-branch-clone]

  switch has 2 consecutive identical branches

     52 |         case 'h':
        |         ^
  /home/runner/work/ext-pexact/ext-pexact/abc/src/ext-pexact/init.cpp:55:23: note: last of these clones ends here
     55 |             goto usage;
        |                       ^

• init.cpp:68:25: warning: [readability-math-missing-parentheses]

  '*' has higher precedence than '+'; add parentheses to explicitly specify the order of operations

     68 |     if ( pPars->nVars > pPars->nNodes * ( 2 - 1 ) + 1 )
        |                         ^~~~~~~~~~~~~~~~~~~~~~~~~
        |                         (                        )

• init.cpp:89:6: warning: [readability-identifier-naming]

  invalid case style for function 'init'

     89 | void init( Abc_Frame_t * pAbc )
        |      ^~~~
        |      Init
     90 | {
     91 |     Cmd_CommandAdd( pAbc, "pexact", "pexact", Pexact_Command, 0 );
     92 | }
     93 | 
     94 | // called during ABC termination
     95 | void destroy( Abc_Frame_t * pAbc )
     96 | {
     97 | }
     98 | 
     99 | // this object should not be modified after the call to Abc_FrameAddInitializer
    100 | Abc_FrameInitializer_t frame_initializer = { init, destroy };
        |                                              ~~~~
        |                                              Init

• init.cpp:95:6: warning: [readability-identifier-naming]

  invalid case style for function 'destroy'

     95 | void destroy( Abc_Frame_t * pAbc )
        |      ^~~~~~~
        |      Destroy
     96 | {
     97 | }
     98 | 
     99 | // this object should not be modified after the call to Abc_FrameAddInitializer
    100 | Abc_FrameInitializer_t frame_initializer = { init, destroy };
        |                                                    ~~~~~~~
        |                                                    Destroy

• init.cpp:100:24: warning: [readability-identifier-naming]

  invalid case style for global variable 'frame_initializer'

    100 | Abc_FrameInitializer_t frame_initializer = { init, destroy };
        |                        ^~~~~~~~~~~~~~~~~
        |                        s_frame_initializer
    101 | 
    102 | // register the initializer a constructor of a global object
    103 | // called before main (and ABC startup)
    104 | struct registrar {
    105 |     registrar()
    106 |     {
    107 |         Abc_FrameAddInitializer( &frame_initializer );
        |                                   ~~~~~~~~~~~~~~~~~
        |                                   s_frame_initializer

• init.cpp:104:8: warning: [readability-identifier-naming]

  invalid case style for struct 'registrar'

    104 | struct registrar {
        |        ^~~~~~~~~
        |        Registrar_t_
    105 |     registrar()
        |     ~~~~~~~~~
        |     Registrar_t_

• init.cpp:109:3: warning: [readability-identifier-naming]

  invalid case style for global variable 'pexact_registrar'

    109 | } pexact_registrar;
        |   ^~~~~~~~~~~~~~~~
        |   s_pexact_registrar

Have any feedback or feature suggestions? Share it here.